2008/12/8 Todd C. Miller <[EMAIL PROTECTED]>:
> In message <[EMAIL PROTECTED]>
>        so spake "Andreas Kahari" (andreas.kahari):
>
>> Ah, I think I found it.  It is this line in my sudoers file that does it:
>>
>> %users ALL=(ALL) NOPASSWD: /usr/local/libexec/xfsm-shutdown-helper
>>
>> What's wrong with it? I was intending to let any member of the 'users'
>> group execute the xfsm-shutdown-helper program, but this line has the
>> side effect of making "sudo -v" not work properly.
>
> The following patch should fix the behavior.  I need to do some
> checking to make sure there are no other side effects but I believe
> it is correct.
>
>  - todd


Yes, the patch seems to be fixing it. I can't say anything about other
side effects though.


Thanks,
Andreas



>
> Index: parse.c
> ===================================================================
> RCS file: /home/cvs/openbsd/src/usr.bin/sudo/parse.c,v
> retrieving revision 1.20
> diff -u -p -u -r1.20 parse.c
> --- parse.c     14 Nov 2008 11:58:08 -0000      1.20
> +++ parse.c     8 Dec 2008 14:54:56 -0000
> @@ -192,12 +192,9 @@ sudo_file_lookup(nss, validated, pwflag)
>                    if ((pwcheck == any && nopass != TRUE) ||
>                        (pwcheck == all && nopass != FALSE))
>                        nopass = cs->tags.nopasswd;
> -                   if (match == ALLOW)
> -                       goto matched_pseudo;
>                }
>            }
>        }
> -       matched_pseudo:
>        if (match == ALLOW || user_uid == 0) {
>            /* User has an entry for this host. */
>            SET(validated, VALIDATE_OK);
>



-- 
Andreas Kahari
Somewhere in the general Cambridge area, UK

Reply via email to