On Wed, Jul 17, 2013 at 12:43:23AM +0200, Gilles Chehade wrote: > > --- a/contrib/lib/libc/asr/asr_debug.c 2013-07-15 21:14:05.000000000 > > +0600 > > +++ b/contrib/lib/libc/asr/asr_debug.c 2013-07-17 00:26:40.000000000 > > +0600 > > @@ -286,8 +286,12 @@ > > PRINTOPT(RES_STAYOPEN, "STAYOPEN"); > > PRINTOPT(RES_DNSRCH, "DNSRCH"); > > PRINTOPT(RES_NOALIASES, "NOALIASES"); > > +#ifdef RES_USE_EDNS0 > > PRINTOPT(RES_USE_EDNS0, "USE_EDNS0"); > > +#endif > > +#ifdef RES_USE_DNSSEC > > PRINTOPT(RES_USE_DNSSEC, "USE_DNSSEC"); > > +#endif > > if (o) > > fprintf(f, " 0x%08x", o); > > fprintf(f, "\n"); > > eric ?
See below > > -------------- < cut here > -------------- > > > > 1) There are only SSL_OP_NO_TICKET, RES_USE_EDNS0 and RES_USE_DNSSEC > > options presence checks. If they are declared (in modern OSes, by default) > > they are used, otherwise they are omitted. > > > > 2) SSL_OP_NO_TICKET was introduced in openssl-0.9.9, and thus isn't > > supported on RHEL5 and such platforms. I've tested TLS and SSL local > > connections on RHEL5, and they work fine. Although I haven't tested > > outgoing TLS connections yet, but I doubt they would fail. > > > > I'm ok with that, what I'm not happy with is adding ifdef's to the code > when not absolutely necessary :-) > > > > 3) RES_USE_EDNS0 and RES_USE_DNSSEC options are missed in old GLIBC. They > > prescript to use DNSSEC for security reasons, but their using or dismissing > > won't break the program's core functionality. > > > > eric ? I agree that we should not add too many #ifdef in the code. It's better to define them to 0 (or whatever unused values) in config.h and leave the code untouched. Eric. -- You received this email because you are subscribed to the "[email protected]" list To unsubscribe, send mail with subject: [[email protected]] unregister
