On Mon, Aug 26, 2013 at 7:26 PM, Gilles Chehade <[email protected]>
wrote:
> 3- The diff I committed was written in ten minutes after a discussion on
IRC
> where someone suggested that we DON'T remove the Received line but simply
> skip part of it. This turned out to be acceptable as the line still
The one I posted added these options:
+received : HIDERECEIVED { $$ = F_HIDE_RECEIVED; }
> + | MASKRECEIVED { $$ = F_MASK_RECEIVED; }
to add support for both hiding (which you don't want) and masking (which
you wrote yourself).
The reason I'm surprised is because a while back when I proposed this and
submitted a patch, it was pretty heavy handedly dismissed:
I understand the task you're trying to accomplish but it seems like it's
> something we want done through filters, not with new config keywords.
If we go that path, next week someone will ask for another config knob
> to enable disable another header, and we end up with tons of keywords
> to deal with every single use-case.
> The filter API (in progress) let's you rewrite / skip lines before they
> hit the queue so what you're trying to achieve can be written with a
> few lines of C without the base even requiring a change.
> I suggest you use github as it
> allows us to just pull requests we want
Ahhh. This is the useful constructive bit to come out of this thread for
me: OpenSMTPD prefers github pull requests. Noted. Most other open source
project I've contributed to that have mailing list prefer the more
traditional git-send-email generated mailing list posts, where the patch is
then debated and eventually applied. For OpenSMTPD, I'll be sure to
remember to githubify it instead.
By the way, regarding a potential hide-received flag and whether or not to
use the filter API for it -- these lines become hard to parse when they're
multiple lines. But not only that -- it's not even passed to the filter API
right now because it's appended directly to the file, so AFAIK, there's no
way to filter it out. It just seems nicer to prevent it from being written
at all, rather than have to monkey wrench it off with a filter. Pretty
please?
