On Sun, May 19, 2019 at 12:16:40PM +0200, David Flatz wrote:
> Gilles Chehade (2019-05-19 10:39+0200):
> > On Sun, May 19, 2019 at 10:24:07AM +0200, Gilles Chehade wrote:
> > > On Sat, May 18, 2019 at 02:55:05PM +0200, David Flatz wrote:
> > > > Delivery to dovecot works pretty good for normal mails locally with 
> > > > sendmail
> > > > and from remote.  However, when opensmtpd generates a bounce dovecot 
> > > > won't
> > > > accept it and returns following error message "501 5.5.4 Invalid FROM:
> > > > Missing domain".
> > > >
> > > > [...]
> > > >
> > > > It seems like opensmtpd uses an envelope from for the bounces that 
> > > > dovecot
> > > > doesn't like.  Is there a way to make opensmtpd to either use an empty
> > > > envelope from (since those seem fine to dovecot) or add a domain?
> > > >
> > > > Thanks again and have a great weekend!
> > > >
> > > 
> > > Yup, the fix will be committed to -current today
> > > 
> > 
> > can you test the following diff and tell me if it makes things better ?
> > 
> > it essentially reverts a commit from months ago which we thought was the
> > proper way to deal with this, but was actually made necessary because of
> > another issue in mda_variables.c
> > 
> > I think this diff should properly fix your issue.
> > 
> > [...]
> 
> Thanks for the diff.  I get this error with a similar diff (I'm using
> portable 6.4.1p2):
> 
> smtpd[6600]: 0000000000000000 mda delivery evpid=4bbf012508df6894 from=<> 
> to=<m...@email.com> rcpt=<m...@email.com> user=username delay=0s 
> result=PermFail stat=Error ("smtpd: No such file or directorymda command line 
> could not be expanded")
> 
> --- smtpd/parse.y     2018-12-17 13:58:15.000000000 +0100
> +++ smtpd/parse.y     2019-05-19 10:58:38.678223391 +0200
> @@ -617,11 +617,11 @@
> } dispatcher_local_options
> | LMTP STRING {
>       asprintf(&dispatcher->u.local.command,
> -         PATH_LIBEXEC"/mail.lmtp -f %%{mbox.from} -d %s %%{user.username}", 
> $2);
> +         PATH_LIBEXEC"/mail.lmtp -f \"%%{sender}\" -d %s %%{user.username}", 
> $2);
> } dispatcher_local_options
> | LMTP STRING RCPT_TO {
>       asprintf(&dispatcher->u.local.command,
> -         PATH_LIBEXEC"/mail.lmtp -f %%{mbox.from} -d %s %%{dest}", $2);
> +         PATH_LIBEXEC"/mail.lmtp -f \"%%{sender}\" -d %s %%{dest}", $2);
> } dispatcher_local_options
> | MDA STRING {
>       asprintf(&dispatcher->u.local.command,
> 

care to try building from the github repo ?

my diff assumes a previous fix to mda_variables.c:

https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.sbin/smtpd/mda_variables.c.diff?r1=1.4&r2=1.5&f=h

"""
in mda variables expansions, do not consider empty strings as errors since
an empty %{sender} is really a mailer-daemon and not an error

reported and initial diff by Lauri Tirkkonen <loth...@iki.fi>
commit is a revised version of the diff based on a discussion with eric@
"""

It was committed five months ago, after 6.4.1p2 which is why you get the
error with my new diff.


-- 
Gilles Chehade                                                 @poolpOrg

https://www.poolp.org                 tip me: https://paypal.me/poolpOrg

-- 
You received this mail because you are subscribed to misc@opensmtpd.org
To unsubscribe, send a mail to: misc+unsubscr...@opensmtpd.org

Reply via email to