Hi, I don't see a problem with fixing these warnings. We just have to make sure somehow that no new files with missing newlines are committed (we do not continuously test with gcc 4.1 for example).
- Sascha On 05/30/2012 11:45 AM, Fetzer, Andreas wrote: > Hi Matt, > > since a while MITK Core is warning free. In order that this doesn't change we > decided to treat each new warning as error. Since you are using an rather old > version of gcc this "no newline at end of file" warning occurs. (Which is now > treated as error.) If I am informed correctly this warning doesn't occur with > gcc>= 4.3. > > You could now use a newer compiler or you have to remove the WError flag > manually for this specific build. > > Regards > Andreas > > On 30.05.2012, at 10:33, Clarkson, Matt wrote: > > Hi there, > > I am doing a build of a recent version of MITK, and at one point there are > warnings: > > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/Utilities/mbilog/mbilogBackendCout.h:65:7: > warning: no newline at end of file > In file included from > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/BlueBerry/Bundles/org.blueberry.osgi/src/berryLog.h:20, > from > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/BlueBerry/Bundles/org.blueberry.ui.qt.log/src/internal/berryQtPlatformLogModel.h:20, > from > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/MITK-build/MITK-build/BlueBerry/Bundles/org.blueberry.ui.qt.log/src/internal/moc_berryQtPlatformLogModel.cxx:10: > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/Utilities/mbilog/mbilog.h:225:7: > warning: no newline at end of file > [ 49%] Building CXX object > BlueBerry/Bundles/org.blueberry.ui.qt.log/CMakeFiles/org_blueberry_ui_qt_log.dir/qrc_org_blueberry_ui_qt_log.cxx.o > [ 49%] Building CXX object > BlueBerry/Bundles/org.blueberry.ui.qt.log/CMakeFiles/org_blueberry_ui_qt_log.dir/qrc_org_blueberry_ui_qt_log_manifest.cxx.o > [ 49%] Building CXX object > BlueBerry/Bundles/org.blueberry.ui.qt.log/CMakeFiles/org_blueberry_ui_qt_log.dir/qrc_org_blueberry_ui_qt_log_cached.cxx.o > Linking CXX shared library ../../../bin/plugins/liborg_blueberry_ui_qt_log.so > > > But then, they switch to errors and the build stops: > > [ 50%] Built target org_blueberry_ui_qt_log > [ 50%] Building CXX object > Core/Code/CMakeFiles/Mitk.dir/Algorithms/mitkBaseDataSource.cpp.o > In file included from > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/Utilities/mbilog/mbilogBackendBase.h:21, > from > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/Utilities/mbilog/mbilog.h:23, > from > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/Core/Code/IO/mitkLogMacros.h:20, > from > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/Core/Code/DataManagement/mitkCommon.h:29, > from > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/Core/Code/Algorithms/mitkBaseProcess.h:26, > from > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/Core/Code/Algorithms/mitkBaseDataSource.h:21, > from > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/Core/Code/Algorithms/mitkBaseDataSource.cpp:18: > /var/drc/scratch1/NifTK/build/NifTK-SuperBuild-Release/CMakeExternals/Source/MITK/Utilities/mbilog/mbilogLogMessage.h:81:7: > error: no newline at end of file > > This is occuring once I merged MITK version 53aba30c0c into our MITK fork, on > Slackware, running gcc 4.1.2. > > Any ideas? > > Thanks > > MAtt > > > > > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. > http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________ > mitk-users mailing list > [email protected]<mailto:[email protected]> > https://lists.sourceforge.net/lists/listinfo/mitk-users > > > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > mitk-users mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mitk-users ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ mitk-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mitk-users
