Hi Matt, some collected comments on your issues. I already might have fixed one or two issues during the last two days (merge to come today) and will look into the rest later, however it might take some time until I find enough time.
On 20.06.2012 22:48, Clarkson, Matt wrote: > *Issue 1. Tag 0020,0037 patient orientation not consistent within one > volume causes volume to be split.* > > I have raised bug: > http://bugs.mitk.org/show_bug.cgi?id=12263 > > Checked code in here: > https://github.com/MattClarkson/MITK/commit/1b01013ab8f0a104a060e4eaa4d5048be42e9253 > > and put test data on dropbox, in folder bug-12263. I already had a look and commented two topics pointed out in your branch on github (https://github.com/MattClarkson/MITK/commit/1b01013ab8f0a104a060e4eaa4d5048be42e9253#L0L438). I'll download your testdata and try to understand the problem. > > *Issue 4. Series Instance UID may be missing.* > > Currently with images I have tested, this throws a segmentation fault > without an error message. > > I have raised bug: > http://bugs.mitk.org/show_bug.cgi?id=12277 > > Checked code in here: > https://github.com/MattClarkson/MITK/commit/86ca4266b6dfd1cc803a87a9d73eb30654154652 > > unfortunately I don't have permission to give you the exact test data > for this one. Thanks for this fix, an exception is definitely better here than a segfault. > > *Issue 5, and 6.* > > Resolved. It was not a DICOM issue. > > An additional issue that we found was a crash if the DICOMDIR folder was > present in a folder containing a load of DICOM images. > > So, I have raised bug: > http://bugs.mitk.org/show_bug.cgi?id=12276 > > Checked code in here: > https://github.com/MattClarkson/MITK/commit/b9b6960de1747696333c64b93d810d5ed046316e Thanks for this fix, this is making things more reliable. I'll integrate it. > > *Issue 2 and 3. Tag 0020,0037 (patient orientation) or 0020,0032 > (patient position) may be missing.* > > I agree with your comments. In fact these two issues of mine are > misleading. I now realise that each image is a 3D SPECT reconstruction, > so the whole 3D image comes in one file with a .dcm ending. So, the > mitkDicomSeriesReader is not reading them,..... because they are not a > series! > So the question is .... how should we load 3D SPECT? I currently don't > have a solution. I have included test data on dropbox in folder SPECT-3D. > In answer to your question on secondary capture, i think it would be > more wrong to load an image with wrong orientation, spacing and slice > thickness. > > Also, having looked at the 3D SPECT images.... these seem to have tag > 0008,0060 (modality)=OT so the suggested code here: > https://github.com/maleike/MITK/commit/d1ab612fc78f93963062c97d7c4d4ac70e5b0876#L0L583 > > would treat these SPECT images incorrectly. > > So, as it stands, I think we still need a different solution for SPECT > and SecondaryCapture, and do not currently agree with this code: > https://github.com/maleike/MITK/commit/d1ab612fc78f93963062c97d7c4d4ac70e5b0876#L0L583 > I now cleaned up the patch I produced when looking into this missing-tag-problem first (http://bugs.mitk.org/show_bug.cgi?id=12280). Now I just read your comments below and will re-think this issue. Maybe we can find a solution where an application Regarding the 3D images (probaly multiframe DICOM), I know this is definitely not supported by MITK. Last time I tried that I think I found a part in either ITK or GDCM which would prohibit that. Also, so far I personally did not run into such images in "my" practice. I would welcome if we could teach MITK (or ITK/GDCM) to load such images, but I guess this would require a major change in any of those toolkits. Regards, Daniel -- Dr. Daniel Maleike Telefon: + 49 6221 647976 3 Mint Medical GmbH, Friedrich-Ebert-Straße 2, 69221 Dossenheim/Heidelberg Geschäftsführer: Dr. Matthias Baumhauer Registergericht Mannheim, HRB 709351 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ mitk-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mitk-users
