Hi there,

following our upgrade to MITK 2014.10, it looks to me like the code for 
preloading libraries in MITK Workbench is a bit  … er … not what I expect.

In 2014.03 we had:
https://github.com/MITK/MITK/blob/eb025ddf02d2d7c60eada2f68dab39274420dea8/Applications/Workbench/MitkWorkbench.cpp

In the latest master we have:
https://github.com/MITK/MITK/blob/master/Applications/Workbench/MitkWorkbench.cpp

So, in 2014.03 we try to pre-load both liborg_mitk_gui_qt_ext and CTKDICOMCore 
(on non-windows platforms).
In 2014.10 we try to load only liborg_mitk_gui_qt_ext.

Q1: Is CTKDICOMCore no longer needed to be pre-loaded. I seem to remember that 
some install path in some version of DCMTK was fixed (Andreas/Sascha maybe) so, 
maybe we don’t need to preload it.

Q2: In both of these cases, the code looks to me like it will only pre-load one 
library. If you wanted to specify a list of libraries to pre-load, the 2014.03 
version doesn’t contain a loop to set the path correctly for each library. In 
the latest master, there is a loop over the entries in a QStringList, which 
calculates either the build-tree path or the install-tree path, but then the 
preloadConfig variable simply ignores it, so the final value passed to 
extConfig->setString(berry::Platform::ARG_PRELOAD_LIBRARY, 
preloadConfig.toStdString()); will never contain the right path (on a Mac at 
least). 

Any thoughts? It looks wrong to me…. or I need more coffee today.

Matt


------------------------------------------------------------------------------
New Year. New Location. New Benefits. New Data Center in Ashburn, VA.
GigeNET is offering a free month of service with a new server in Ashburn.
Choose from 2 high performing configs, both with 100TB of bandwidth.
Higher redundancy.Lower latency.Increased capacity.Completely compliant.
http://p.sf.net/sfu/gigenet
_______________________________________________
mitk-users mailing list
mitk-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mitk-users

Reply via email to