Hi I filed bug for this.
https://bugs.launchpad.net/mixxx/+bug/1100898 best Max On Sat, 12 Jan 2013 22:29:11 +0100 Daniel Schürmann <[email protected]> wrote: > Hi Max > > Thank you for your diligence work! > > Can you please file a bug and attach you patch there? > It better to track it there. > > Can you explain you changes to > mixxx/src/controllers/controllerlearningeventfilter.cpp? > Else the patch looks good to me. > > I agree to Owen, this is a candidate for lp:mixxx. > > Partly there are comments without a leading blank in the unchanged > patch lines. Is it wort to fix this at well? > > Kind regards, > > Daniel > > > > > > > 2013/1/12 Owen Williams <[email protected]> > > > This type of big churning patch would be a candidate for a trunk > > commit (as opposed to 1.11) since it's going to cause tons of merge > > problems in other branches. > > > > O > > n Sat, 2013-01-12 at 13:55 +0100, Max Linke wrote: > > > Hi > > > > > > I made a patch to remove the compiler warnings and clean up the > > > code a bit. It should remove around 95% of all warnings. For this > > > I also removed/changed some variables so it would be nice if > > > someone could look over it before I commit it. > > > > > > best Max > > > > > ------------------------------------------------------------------------------ > > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, > > CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your > > skills current with LearnDevNow - 3,200 step-by-step video > > tutorials by Microsoft MVPs and experts. SALE $99.99 this month > > only -- learn more at: http://p.sf.net/sfu/learnmore_122912 > > > _______________________________________________ > > > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > > > http://mixxx.org > > > > > > > > > Mixxx-devel mailing list > > > [email protected] > > > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > > > > > > > ------------------------------------------------------------------------------ > > Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, > > MVC, Windows 8 Apps, JavaScript and much more. Keep your skills > > current with LearnDevNow - 3,200 step-by-step video tutorials by > > Microsoft MVPs and experts. SALE $99.99 this month only -- learn > > more at: http://p.sf.net/sfu/learnmore_122912 > > _______________________________________________ > > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > > http://mixxx.org > > > > > > Mixxx-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_122712 _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
