I finally got it compile on my machine. I sent a PR with all the changes I made :
https://github.com/mixxxdj/mixxx/pull/743 sb Le 16/10/2015 00:31, Sébastien Blaisot a écrit : > in fact, both of them need to be replaced with > TAGLIB_FILENAME_FROM_QSTRING(getFilename()) > > sb > > Le 16/10/2015 00:24, Sébastien Blaisot a écrit : >> sorry, wrong line. >> >> I meant >> https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L396 >> >> sb >> >> Le 16/10/2015 00:09, Sébastien Blaisot a écrit : >>> Probably you also need to patch this : >>> https://github.com/mixxxdj/mixxx/blob/1.12/plugins/soundsourcemediafoundation/soundsourcemediafoundation.cpp#L105 >>> >>> I have a link-time error (unresolved external symbol) for >>> soundsourcemediafoundation >>> >>> sb >>> >>> Le 15/10/2015 23:59, Daniel Schürmann a écrit : >>>> Nice! Then I will prepare a commit, using this. >>>> >>>> Am 15.10.2015 um 23:57 schrieb Sébastien Blaisot: >>>>> I have no idea. >>>>> It is available in Visual Studio 2010, 2012, 2013 and 2015 >>>>> https://msdn.microsoft.com/fr-fr/library/hh567368.aspx#featurelist >>>>> but I don't know if it is dependant of an option at compile time. >>>>> >>>>> I know it works perfectly for me, out of the box (no special >>>>> configuration for VC) using scons and mixxx 1.12 config ;) >>>>> >>>>> sb >>>>> >>>>> Le 15/10/2015 23:50, Daniel Schürmann a écrit : >>>>>> Is this available on VC without c++11 support? >>>>>> >>>>>> Am 15.10.2015 um 23:41 schrieb Sébastien Blaisot: >>>>>>> As we are in a #ifdef _WIN32, why not using native static_assert ? >>>>>>> https://msdn.microsoft.com/fr-fr/library/dd293588.aspx >>>>>>> >>>>>>> sb >>> ------------------------------------------------------------------------------ >>> _______________________________________________ >>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >>> http://mixxx.org >>> >>> >>> Mixxx-devel mailing list >>> Mixxx-devel@lists.sourceforge.net >>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel >> ------------------------------------------------------------------------------ >> _______________________________________________ >> Get Mixxx, the #1 Free MP3 DJ Mixing software Today >> http://mixxx.org >> >> >> Mixxx-devel mailing list >> Mixxx-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > ------------------------------------------------------------------------------ > _______________________________________________ > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > http://mixxx.org > > > Mixxx-devel mailing list > Mixxx-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/mixxx-devel ------------------------------------------------------------------------------ _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
