Garth Dahlstrom wrote: > > + if (v > 1.0) m_pView->m_pTrackTableView->moveNext(); > > Those should be (v >= 1.0) or just (v), right? > > ( Pretty sure Herc's send only 0 (up) and 1 (down) for buttons nothing > more 1... ) > > Cheers, > > -G Well, I had a reason for this, of course. When testing with my MIDI keyboard, which emits KeyOn and KeyOff, I saw v=127.0 on KeyOn, and v=1.0 on KeyOff. This is admittedly weird behaviour, which I'll try to understand/fix tomorrow.
So, your version of testing against (v) is probably correct. I've just finished renaming and documenting all functions, as Albert told me to, so I think we'll have a finished patch tomorrow. 'Til later, - Ján ------------------------------------------------------------------------- SF.Net email is sponsored by: Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
