Hi Ján, I've reviewed, tested, and committed your updated patch. Nothing seemed to break when I tested it with one of my MIDI controllers, so if anyone notices any odd MIDI stuff with ALSA on Linux in the next week or so, please speak up!
While I was testing I noticed a minor bug in alsaseq MIDI code we have (unrelated to your patch). Sometimes when you select a different MIDI device in the options, it doesn't properly disconnect from the previous one, leaving you with two devices hooked up to the Mixxx aseq port. (If you crack open the Connect/MIDI tab in qjackctl, you'll see what I mean.) It's not a biggie, but if someone feels like fixing it, be my guest. :) Thanks, Albert On Tue, 2008-01-08 at 12:07 +0100, Jan Jockusch wrote: > Hello list, > > I know everyone is deep into testing, but I think one small bonus should > be added for us Jack/ALSA users, which is LED control via MIDI. I > implemented this specifically to enable LED control on my DM2, but > others will surely benefit as well. > > Albert and Adam: I am about the farthest from an ALSA API expert you can > imagine, so please check what I did. I believe that the flags are all > right, I think SND_SEQ_PORT_CAP_DUPLEX is unnecessary. I also found that > the constructor does not need to connect the port, because the > subsequent devOpen() call does just that, so I removed that segment. > > I hope this is good to commit. > > - Ján > > ------------------------------------------------------------------------- > Check out the new SourceForge.net Marketplace. > It's the best place to buy or sell services for > just about anything Open Source. > http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace > _______________________________________________ > Mixxx-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mixxx-devel ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
