On Thu, Mar 27, 2008 at 04:59:47PM -0400, Alex Markley wrote:
> Index: src/configobject.cpp
> ===================================================================
> --- src/configobject.cpp      (revision 1900)
> +++ src/configobject.cpp      (working copy)
> @@ -355,11 +355,14 @@
>      }
>      else if (midioption == MIDI_OPT_DIFF)
>      {
> -        if (_newmidivalue > 64.) {
> -            _newmidivalue = _prevmidivalue - 128. + _newmidivalue;
> -        } else {
> -            _newmidivalue = _prevmidivalue + _newmidivalue;
> -        }
> +        //Interpret 7-bit signed value using two's compliment.
> +        if (_newmidivalue >= 64.)
> +            _newmidivalue = _newmidivalue - 128.;
> +        //Apply sensitivity to signed value.
> +        if(sensitivity > 0)
> +            _newmidivalue = _newmidivalue * ((double)sensitivity / 50.);
> +        //Apply new value to current value.
> +        _prevmidivalue = _prevmidivalue + _newmidivalue;

Should that last line be

           _newmidivalue = _prevmidivalue + _newmidivalue;

?

Otherwise it seems like the formula no longer incorporates
the previous value...

Ben


-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to