I just redid the Herc scratch code using 2 decks and committed back in...
Seemed to work when I played with it on the RMX. Hopefully there are no
Assert troubles with the new implementation.
I also just added this #comment to the checks in configobject.cpp, but I
can't test that as my Windows compile environment is broke...
vvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvvv
if ((key.isEmpty() || type.isEmpty()) && node.nodeName() != "#comment")
qWarning() << "Missing <key> or <type> in MIDI map node:" <<
node.nodeName();
If someone building on windows can compile that, and then put a <!-- -->
into their midi config to confirm that it no longer barfs on the comments,
that would be helpful.
Cheers,
-G
On Sun, Mar 30, 2008 at 5:26 PM, Albert Santoni <[EMAIL PROTECTED]> wrote:
> Hey Garth,
>
> Pawel was getting asserts on every startup, and we found this line to be
> the problem (Hercules.cpp)
>
> 1902 ironstorm m_pControlObjectScratch = new
>
> ControlObjectThread(ControlObject::getControl(ConfigKey("[Master]","scratch")));
>
>
> As far as I know, we don't have a [Master]/"scratch" control, which
> would explain the ASSERT. Mind if I comment that out until you finish
> it?
>
> (We'd have to create the actual controlobject elsewhere, maybe in
> EngineMaster? I don't really know...)
>
> Thanks,
> Albert
>
> P.S. Yorick was getting those ASSERTs too...
>
>
--
__
--- == __/ t.O ==--
http://stacktrace.org/
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
