On Thu, 2008-04-03 at 10:56 -0700, Tom Jennings wrote: > On Thu, 3 Apr 2008, Albert Santoni wrote: > > > Just committed this one, it indeed does fix the compile on OS X. (I > > wonder when this broke...?) > > When I bulk-repaired the qDebug() invokations, some of the > source files didn't include Q[t]Debug. I hand-fixed just enough > to compile. Since I did so on ubuntu only likely I missed > something like / #if OSX ... / > > You or Ben or someone pointed out the relationship between > QDebug.h, QtDebug.h etc. I have been considering normalizing all > the source files to contain one instance of QtDebug.h, period. > I've got code to do such things.
If you #include <QtCore>, then you automatically get all the qDebug stuff... > > Maybe some of those deprecated Qt function calls would benefit > from a mechanical solution. I can offer that much. When we ported from Qt3 to Qt4, we ran this qt3to4 tool that Trolltech provides and it did a fair amount of replacements, although there's still lots of stuff it didn't change over (hence the warnings). I don't know how many more warnings could be eliminated with an automated script.... I'm about to hop on a plane, so perhaps I'll take a crack at killing off more warnings when I'm on it. I might also try to write a dummy EngineBufferScale* class that we can use to temporarily replace EngineBufferScaleST (the SoundTouch one) to see if it helps us narrow down the cause of the stability problems. Thanks again! Albert ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
