I'd be in favour of removing it. Anyone else? Adam
2008/6/3 Russell Ryan <[EMAIL PROTECTED]>: > Hi all, > > In my browsings I noticed some places where there seems to be unused code. > An example would be wavesummary.cpp/h: > > WaveSummary:: > window > windowedSamples > windowPtr > m_pEngineSpectralFwd > > are all unused (except for being created / destroyed) > > Checking the logs, it looks like that's been there since rev ~880, when > wavesummary seemed to do a lot more than just create the summary pixmap. > > I imagine there's a tradeoff between cleaning up code and leaving it in > favor of not causing problems. What have you guys done in the past? > (Should I submit a patch for something like this? It's at least 2048 > CSAMPLES of wasted space + a WindowKaiser and EngineSpectralFwd instance) > > Cheers, > RJ > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > Mixxx-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
