Hi all, I wrote up a spec for an idea I've had for fixing some of the waveform summary thread issues we've seen.
http://mixxx.org/wiki/doku.php/waveform_thread_refactor There were two bugs mentioning that after a while the waveform view would no longer render waveforms, while the rest of Mixxx was responsive. It looks like this was a bug with the waveform downsampling code where the thread would walk into an infinite loop. While that's been patched, there are still some reasons for this change. First, if there is a problem with waveform downsampling that causes a similar infinite loop in the future, if it's contained to one thread per TrackInfoObject, then the next time someone queues a track, the stalled thread goes away, and a new one starts on the track that was just queued. Second, it solves the issue of who "owns" the waveform buffers. If the per-track WaveSummary object is in charge, then it can also be in charge of deletion, etc. Comments? Do we need this? I cut a branch for getting this functionality working, it's named rryan-wavesummary-refactor. I'm probably a little more than half-done. RJ ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
