While I'm on a mixxx-devel streak, I might as well add an update about
the LADSPA window integration itself. :)
I've got it working on OS X now (and potentially Win32) too, but
there's this bug where the ON/OFF WPushButton for each effect just
doesn't work. If you try toggling it, it doesn't turn on the effect. I
hardcoded a "button->set(1.0f)" call in the LADSPA code to force the
button to be on, and the effects do actually work. After putting some
qDebugs in the code, the state of the button definitely isn't being
toggled, yet somehow the image changes between ON/OFF correctly. I
don't understand how the WPushButton code hooks into a ControlObject
yet, and although I've spent about 2 hours poking at it, it's still
not clear.
The thing that's odd is that all the other WPushButtons in the main
Mixxx window work fine, but these ON/OFF LADSPA buttons don't. (If you
look in ladspapresetslot.cpp, I'm talking about m_pEnableButton.) The
"remove" button (the little X for removing a LADSPA effect) works fine
as well, but it directly uses signals/slots and doesn't use a
ControlObject. I'd be curious to know if this is just a Mac problem,
but I don't want to commit broken code.
If someone's interested in testing it on Linux or Windows (even
better), I can post a patch to mixxx-devel in the meantime....
Thanks,
Albert
On 19-Oct-08, at 9:16 PM, Albert Santoni wrote:
> Ok, hopefully fixed Linux this time, lol :)
> (r2326)
>
>
> On 19-Oct-08, at 8:44 PM, Garth Dahlstrom wrote:
>
>>
>> [EMAIL PROTECTED]:~/workspace/Mixxx$ scons -c
>> scons: Reading SConscript files ...
>> Platform: Linux
>> NameError: name 'capslib_tgt' is not defined:
>> File "/home/ged/workspace/Mixxx/SConstruct", line 2:
>> SConscript(File('lib/ladspa/SConscript'), build_dir=Dir('lib/
>> ladspa/.obj'), duplicate=0)
>> File "/usr/lib/scons/SCons/Script/SConscript.py", line 596:
>> return apply(method, args, kw)
>> File "/usr/lib/scons/SCons/Script/SConscript.py", line 533:
>> return apply(_SConscript, [self.fs,] + files, subst_kw)
>> File "/usr/lib/scons/SCons/Script/SConscript.py", line 256:
>> exec _file_ in call_stack[-1].globals
>> File "/home/ged/workspace/Mixxx/lib/ladspa/SConscript", line 4:
>> SConscript(['caps/SConscript'], exports='env')
>> File "/usr/lib/scons/SCons/Script/SConscript.py", line 596:
>> return apply(method, args, kw)
>> File "/usr/lib/scons/SCons/Script/SConscript.py", line 533:
>> return apply(_SConscript, [self.fs,] + files, subst_kw)
>> File "/usr/lib/scons/SCons/Script/SConscript.py", line 256:
>> exec _file_ in call_stack[-1].globals
>> File "/home/ged/workspace/Mixxx/lib/ladspa/caps/SConscript", line
>> 26:
>> env.Alias('install', capslib_tgt)
>>
>>
>>
>> On Sun, Oct 19, 2008 at 11:33 PM, Albert Santoni <[EMAIL PROTECTED]>
>> wrote:
>> Should be fixed now Nick, can you svn update and try again?
>>
>> Thanks,
>> Albert
>>
>> On 18-Oct-08, at 11:54 PM, Nick Guenther wrote:
>>
>>> On Tue, Oct 7, 2008 at 3:10 AM, Albert Santoni <[EMAIL PROTECTED]>
>>> wrote:
>>>>
>>>> On 6-Oct-08, at 11:08 PM, Nick Guenther wrote:
>>>>>>
>>>>>
>>>>> None here. For the purposes on documenting how to get Mixxx
>>>>> compiling,
>>>>> where should ladspa.h live? Is there a source package to download
>>>>> that
>>>>> you can `make` or are we just supposed to save
>>>>> http://www.ladspa.org/ladspa_sdk/ladspa.h.txt to /usr/local/
>> include?
>>>>>
>>>>> -Nick
>>>>
>>>>
>>>> You're way ahead of me here. After my experience tonight getting
>>>> all these
>>>> LADSPA plugins to compile on OS X (I had to modify all their
>>>> makefiles), I'm
>>>> starting to think that we should just roll the LADSPA plugins we
>>>> want into
>>>> our source tree, along with ladspa.h. All the LADSPA plugins I
>>>> compiled can
>>>> be turned into single dynamic libraries (I think), and SCONS will
>>>> do a
>>>> better job at building them, as most of the plugins I compiled only
>>>> have a
>>>> Makefile (no autotools).
>>>>
>>>> We might get flak from the distro people for doing this, but it'll
>>>> let us
>>>> deploy on more platforms faster, and have better quality control.
>>>>
>>>> Oh, and I made some more progress:
>>>> http://imagebin.ca/view/u8n4Qr.html
>>>>
>>>> :)
>>>>
>>>> Thanks,
>>>> Albert
>>>>
>>>
>>>
>>> So I just svn up'd and found that it didn't compile.
>>> First problem: I needed to copy ladspa.h into /usr/local/include (of
>>> course)
>>> Second problem:
>>> Index: lib/ladspa/caps/basics.h
>>> ===================================================================
>>> --- lib/ladspa/caps/basics.h (revision 2324)
>>> +++ lib/ladspa/caps/basics.h (working copy)
>>> @@ -46,7 +46,7 @@
>>> #include <assert.h>
>>> #include <stdio.h>
>>>
>>> -#include "ladspa.h"
>>> +#include <ladspa.h>
>>>
>>> #define BOUNDED (LADSPA_HINT_BOUNDED_BELOW |
>>> LADSPA_HINT_BOUNDED_ABOVE)
>>> #define INTEGER LADSPA_HINT_INTEGER
>>> ===================================================================
>>>
>>>
>>>
>>> Third problem:
>>> scons: Reading SConscript files ...
>>> Platform: OS X
>>> QT path: /usr/local/Trolltech/Qt-4.4.1/
>>> Loading qt4 tool...
>>> Checking for C library portaudio... (cached) yes
>>> Checking for C library mad... (cached) yes
>>> Checking for C library id3tag... (cached) yes
>>> Checking for C library vorbisfile... (cached) yes
>>> Checking for C library vorbis... (cached) yes
>>> Checking for C library ogg... (cached) yes
>>> Checking for C library GL... (cached) no
>>> Checking for C library opengl32... (cached) no
>>> Checking for C header file
>>> /System/Library/Frameworks/OpenGL.framework/Versions/A/Headers/
>> gl.h...
>>> (cached) yes
>>> Checking for C library GLU... (cached) no
>>> Checking for C library glu32... (cached) no
>>> Checking for C header file
>>> /System/Library/Frameworks/OpenGL.framework/Versions/A/Headers/
>>> glu.h...
>>> (cached) yes
>>> Not working FFMPEG support... disabled
>>> Checking for C library sndfile... (cached) yes
>>> Checking for C++ header file
>>> /System/Library/Frameworks/CoreMIDI.framework/Headers/CoreMIDI.h...
>>> (cached) yes
>>>
>>> Features Summary:
>>> ================
>>> libdjconsole support... disabled
>>> High quality EQs... enabled
>>> iPod support... disabled
>>> Shoutcast support... disabled
>>> LADSPA support... disabled
>>> Vinyl Control... enabled
>>> SuperCoolAwesomeScript (name contest pending)... disabled
>>> Optimizations... enabled
>>> gprof profiling support... disabled
>>> Optimizing for this CPU... no
>>> MSVS 2005 hacks... disabled
>>> Force 32-bit compile... disabled
>>> Case Metrics profiling... disabled
>>> ================
>>> Building with flags: hifieq vinylcontrol optimize=1
>>> ================
>>>
>>> scons: done reading SConscript files.
>>> scons: Building targets ...
>>> g++ -o lib/ladspa/.obj/caps/Compress.os -c -fPIC lib/ladspa/caps/
>>> Compress.cc
>>> g++ -o lib/ladspa/.obj/caps/Phaser.os -c -fPIC lib/ladspa/caps/
>>> Phaser.cc
>>> g++ -o lib/ladspa/.obj/caps/Reverb.os -c -fPIC lib/ladspa/caps/
>>> Reverb.cc
>>> g++ -o lib/ladspa/.obj/cmt/delay.os -c -fPIC lib/ladspa/cmt/
>> delay.cpp
>>> g++ -o lib/ladspa/.obj/cmt/filter.os -c -fPIC lib/ladspa/cmt/
>>> filter.cpp
>>> g++ -o lib/ladspa/.obj/cmt/cmt.dylib -dynamiclib
>>> lib/ladspa/.obj/cmt/delay.os lib/ladspa/.obj/cmt/filter.os
>>> ld: Undefined symbols:
>>> __Z27registerNewPluginDescriptorP14CMT_Descriptor
>>> __ZN14CMT_Descriptor7addPortEiPKciff
>>>
>> __ZN14CMT_DescriptorC1EmPKciS1_S1_S1_P22CMT_ImplementationDataPFPvPK18_LADSPA_DescriptormEPFvS4_EPFvS4_mESD_PFvS4_fESB_
>>> /usr/bin/libtool: internal link edit command failed
>>> scons: *** [lib/ladspa/.obj/cmt/cmt.dylib] Error 1
>>> scons: building terminated because of errors.
>>>
>>>
>>> I don't know how to fix the third problem. :(
>>>
>>> -Nick
>>
>>
>> -------------------------------------------------------------------------
>> This SF.Net email is sponsored by the Moblin Your Move Developer's
>> challenge
>> Build the coolest Linux based applications with Moblin SDK & win
>> great prizes
>> Grand prize is a trip for two to an Open Source event anywhere in
>> the world
>> http://moblin-contest.org/redirect.php?banner_id=100&url=/
>> _______________________________________________
>> Mixxx-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>
>>
>>
>> --
>> __
>> --- == __/ t.O ==--
>> http://stacktrace.org/
>
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's
> challenge
> Build the coolest Linux based applications with Moblin SDK & win
> great prizes
> Grand prize is a trip for two to an Open Source event anywhere in
> the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> _______________________________________________
> Mixxx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
