It looks like it's there, it's just not setup to be included by the 
sconscript yet for linux..

Does ladspa.h change that often? If so do we keep our version up to 
date? Depending on ladspa-sdk to build doesn't seem unreasonable (we 
already require the -dev versions of all the other libs we require so 
this isn't that different).. although it would make things harder for 
people whose distros don't provide that package.

Here is the relevant change that (worked for me) made it not require 
ladspa-sdk.

That said, SConscript is a mess, and it has tons of ad-hoc switches on 
OS and so on.. it could use some cleaning :). I only put the lib/ladspa 
include here because that's where the windows one is.

Index: src/SConscript
===================================================================
--- src/SConscript    (revision 2355)
+++ src/SConscript    (working copy)
@@ -323,6 +323,11 @@
if platform == 'win32':
    env.Append(CPPPATH=['../../../mixxx-winlib', '../../lib/ladspa']) 
#If you add more directories, separate them with a semicolon (;)
    env.Append(LIBPATH='../../../mixxx-winlib')
     env.Append(LINKFLAGS = ['/nodefaultlib:libc.lib', 
'/nodefaultlib:libcd.lib',  '/entry:mainCRTStartup'])
 #'/subsystem:windows',
 
+if platform == 'linux':
+    env.Append(CPPPATH=['../../lib/ladspa'])
+
 #Check for dependencies if we're not doing a clean...
 
 if not env.GetOption('clean') and not 
SCons.Util.containsAny(os.sys.argv, ['-h', '--help']):



Garth Dahlstrom wrote:
> You check that in?  Building on Linux still fails when you have no 
> ladspa-sdk package
>
> On Mon, Nov 17, 2008 at 2:10 PM, Albert Santoni <[EMAIL PROTECTED] 
> <mailto:[EMAIL PROTECTED]>> wrote:
>
>     Hold up guys,
>
>     ladspa.h is already included in our source tree here:
>     mixxx/lib/ladspa/ladspa.h
>
>     It looks like I only updated our SConscript to search for ladspa.h
>     there for Windows, so I've changed our SConscript to look for it
>     there on all OSes. So we don't actually depend on any external
>     LADSPA packages, which is how LADSPA is supposed to work (LADSPA
>     is just a single header file that specifies a standard set of
>     symbols that should be resolved in any LADSPA plugin dynamic library.)
>
>     Thanks,
>     Albert
>
>
>
>     On 17-Nov-08, at 5:21 AM, Garth Dahlstrom wrote:
>
>         RJ nailed it
>
>         BTW, here's how to find which package has a header file on
>         Ubuntu (second search form on http://packages.ubuntu.com/) ...
>
>         
> http://packages.ubuntu.com/search?searchon=contents&keywords=ladspa.h&mode=exactfilename&suite=intrepid&arch=any
>         
> <http://packages.ubuntu.com/search?searchon=contents&keywords=ladspa.h&mode=exactfilename&suite=intrepid&arch=any>
>
>
>         On Mon, Nov 17, 2008 at 4:52 AM, Russell Ryan <[EMAIL PROTECTED]
>         <mailto:[EMAIL PROTECTED]>> wrote:
>         Robin Sheat wrote:
>         > So, doing a mixxx build for the first time in a fair while,
>         after doing a
>         > clean checkout just to be sure:
>         >
>         > [EMAIL PROTECTED]:~/src/Mixxx/mixxx$ scons
>         > scons: Reading SConscript files ...
>         > Platform: Linux
>         > QT path: /usr/share/qt4
>         > Loading qt4 tool...
>         > Checking for C library portaudio... yes
>         > ....
>         > Checking for C library GLU... yes
>         > Not working FFMPEG support... disabled
>         > Checking for C header file ladspa.h... no
>         > Did not find the LADSPA header file (ladspa.h) - exiting!
>         >
>         > Well, it's right:
>         > [EMAIL PROTECTED]:~/src/Mixxx/mixxx$ dpkg -S ladspa.h
>         > dpkg: *ladspa.h* not found.
>         >
>         > But, on the other hand:
>         > [EMAIL PROTECTED]:~/src/Mixxx/mixxx$ find -name ladspa.h
>         > ./lib/ladspa/ladspa.h
>         >
>         > Is is supposed to be finding this and is failing? I had a
>         look through the
>         > ladspa stuff and build guides on the wiki, none mention this
>         bit.
>         >
>         >
>
>         The 'lib' folder is mostly for OSes that don't have a package
>         system,
>         like Windows. The debian package that provides LADSPA stuff is
>         ladspa-sdk.  If you install that it should work. Now that
>         LADSPA is
>         required, we should update the guides on the wiki to include
>         this :).
>
>         Cheers,
>         RJ
>         >
>         
> ------------------------------------------------------------------------
>         >
>         >
>         
> -------------------------------------------------------------------------
>         > This SF.Net email is sponsored by the Moblin Your Move
>         Developer's challenge
>         > Build the coolest Linux based applications with Moblin SDK &
>         win great prizes
>         > Grand prize is a trip for two to an Open Source event
>         anywhere in the world
>         > http://moblin-contest.org/redirect.php?banner_id=100&url=/
>         <http://moblin-contest.org/redirect.php?banner_id=100&url=/>
>         >
>         
> ------------------------------------------------------------------------
>         >
>         > _______________________________________________
>         > Mixxx-devel mailing list
>         > [email protected]
>         <mailto:[email protected]>
>         > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>         >
>
>
>         
> -------------------------------------------------------------------------
>         This SF.Net email is sponsored by the Moblin Your Move
>         Developer's challenge
>         Build the coolest Linux based applications with Moblin SDK &
>         win great prizes
>         Grand prize is a trip for two to an Open Source event anywhere
>         in the world
>         http://moblin-contest.org/redirect.php?banner_id=100&url=/
>         <http://moblin-contest.org/redirect.php?banner_id=100&url=/>
>         _______________________________________________
>         Mixxx-devel mailing list
>         [email protected]
>         <mailto:[email protected]>
>         https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
>
>
>         -- 
>                      __
>         --- == __/ t.O ==--
>         http://stacktrace.org/
>         
> -------------------------------------------------------------------------
>         This SF.Net email is sponsored by the Moblin Your Move
>         Developer's challenge
>         Build the coolest Linux based applications with Moblin SDK &
>         win great prizes
>         Grand prize is a trip for two to an Open Source event anywhere
>         in the world
>         
> http://moblin-contest.org/redirect.php?banner_id=100&url=/_______________________________________________
>         
> <http://moblin-contest.org/redirect.php?banner_id=100&url=/_______________________________________________>
>         Mixxx-devel mailing list
>         [email protected]
>         <mailto:[email protected]>
>         https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
>
>
>
>
> -- 
>               __
> --- == __/ t.O ==--
> http://stacktrace.org/
> ------------------------------------------------------------------------
>
> -------------------------------------------------------------------------
> This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
> Build the coolest Linux based applications with Moblin SDK & win great prizes
> Grand prize is a trip for two to an Open Source event anywhere in the world
> http://moblin-contest.org/redirect.php?banner_id=100&url=/
> ------------------------------------------------------------------------
>
> _______________________________________________
> Mixxx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>   


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to