I was discussing the patch in #mixxx (irc.freeenode.net) with asantoni and he recommended that I document why this patch is a good idea, so here we go.
The reason I want ramped pitch bending is that is the way CDJ decks operate. This way it is also easier and quicker to ascertain the pitch shift necesarry to match two songs up with a larger range of BPM difference. With static pitch bending it is at best possible to ascertain correctly for a static and limited BPM difference, ie: 0.7% for a BPM difference of 1 BPM, 1.4% (approx.) for 2 BPMs. Most other people will also want ramped pitch bending for the same reasons, since it is how all CDJ decks work and how all other computer mixing programs work. I know for a fact that this is how Traktor works. Two changes that probably need to go into this patch before finally being accepted are: 1) Use rate directly instead of rateSlider->sub() and rateSlider->add() 2) Ramp the pitch bend down on letting go of the pitch bend button. The first point is easy, but the second one should be tabled for the moment since it opens itself up for various weird corner cases involving letting go and pressing pitch bend down rapidly in succesion. Thanks for all the help and advice on #mixxx, especially rryan, Pegasus_RPG and asantoni. -- -----BEGIN GEEK CODE BLOCK----- Version: 3.1 GCS d- s+:- a-- C+++(++++)$ UL+++$ P+ L+++>++++ E W++ N o? K- w++(---) O? M-- V PS+++ PE-(--) Y+(++) PGP t(+) 5(+) X++ R b+>++ DI+ D+ G e h-(--) r y+ ------END GEEK CODE BLOCK------ ------------------------------------------------------------------------------ This SF.net email is sponsored by: SourcForge Community SourceForge wants to tell your story. http://p.sf.net/sfu/sf-spreadtheword _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
