I spotted slight issue with how the engine does compensation/smoothing.
If you have vinyl control setup, please test this patch for me. Let me
know if scratching sounds better (or worse!) with the patch. You may not
even hear a difference. Basically, the engine plugin responsible for
doing vinyl sound emulation is not working with the most up-to-date data.
Thanks,
RJ
Index: mixxx/src/engine/enginebuffer.cpp
===================================================================
--- mixxx/src/engine/enginebuffer.cpp (revision 2530)
+++ mixxx/src/engine/enginebuffer.cpp (working copy)
@@ -1285,6 +1285,11 @@
}
+ // Update the engineRate control object so that EngineVinylSoundEmu
+ // has up-to-date information.
+ rateEngine->set(rate);
+
+
//
// Check if end or start of file, and playmode, write new rate, playpos and do wakeall
// if playmode is next file: set next in playlistcontrol
@@ -1304,7 +1309,7 @@
else
playposSlider->set(0.);
bpmControl->set(filebpm);
- rateEngine->set(rate);
+
m_iSamplesCalculated = 0;
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
