On Tue, 2009-05-19 at 12:47 -0700, Albert Santoni wrote: > Hi Owen, > > That said, I noticed a regression when searching. The changes you made > to searching somehow broke "regular" searches in some way. I have a > bunch of songs by an artist called "Solar Fields", and searching for > "Solar" yields nothing with your patch, even though I can see songs by > that artist in my library. Repeating this search with a clean > 1.7.0-beta1 build yields the proper search results.
I discovered this too. It's because I added the "Played" field into the table model, which changed all of the index numbers for the other fields. The proxymodel.cpp file had the index numbers hard coded, so they are all off by one now. That's an easy fix. > > Since it sounds like you're interested in hacking library stuff, I'd > encourage you to check out the new library code that I was working on: > > svn co > https://mixxx.svn.sourceforge.net/svnroot/mixxx/branches/Features_sqlite/ > mixxx_sqlite > There's still tons of stuff left to do, so any help would be very much > appreciated. Cool, I'll take a look at it. Right now I'm working off of the bazaar tree, is that the right thing to do? I can't figure out which branch is the latest one. > > Because this new library stuff is slated to replace the existing > library code in trunk for Mixxx 1.8, and because we're in feature > freeze for Mixxx 1.7, I'm unfortunately not going to be able to commit > this patch against trunk. If you redo it against the Features_sqlite > branch above (which I don't think will be very much work), I'd be glad > to review it in more detail and commit it. great. I'll see if I can do that. thanks, owen ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
