Hey Navaho, I noticed this too a few weeks ago, and fixed it in my local copy, but I totally forgot to check it into trunk or the 1.7.0 branch. I was scratching my head when I saw this too - I think I must have been in the process of moving the code from main.cpp to ladspaloader.cpp when I got sidetracked, and I just totally forgot about this. (Someone else pointed this out on mixxx-devel about 2 months ago too. eeek!)
Please go ahead and move the LADSPA paths code from main.cpp to ladspaloader.cpp. There shouldn't be any LADSPA code in main.cpp once you're done. I'm away from my PC with these changes on it for the next 2 weeks, so unfortunately I can't commit my changes, but it's only like 5 minutes of work to move the code around. If you want to keep working on LADSPA, you should register a branch in Launchpad and we can help you out where we can. Slide 11 from our 1.8 planning meeting explains the state of the code more or less: https://docs.google.com/Present?docid=dd557nj5_28fvx8jkgx&hl=en Nobody's actively working on LADSPA right now, so please feel free to tweak and polish it. :) Thanks, Albert On Mon, Jun 29, 2009 at 5:33 AM, Navaho Gunleg<[email protected]> wrote: > Hello list, > > Today I was checking out why LADSPA plugins weren't loading on my machine... > also figuring it's a path problem, after reading some LADSPA documentation, > I grepped for LADSPA_PATH and noticed commented-out code in main.cpp that > checks a LADSPA_PATH environment variable. > > Further poking around, in ladspa/ladspaloader.cpp, I noticed a QStringList > plugin_paths being defined, but not assigned... > > When I put the (slightly modified) code from main.cpp that assigns the > ladspaPath, splits it, and assigns it to the plugin_paths variable -- I can > see the loader iterating through the files in the directory, so appears to > be working again. > > Interestingly, in the original main.cpp -- before the commented out code it > prints "Setting up plugin paths" and after it, it prints out "done" but > effectively nothing happens in between. > > > So, it appears to be code that still has to be moved to the > ladspaloader.cpp, or somebody was/is in the process of moving it from the > ladspaloader.cpp to main.cpp? > > I ask because it would not be fruitful to spend time trying to undo somebody > else's work-in-progress if you know what I mean... :-) > > ------------------------------------------------------------------------------ > > _______________________________________________ > Mixxx-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > ------------------------------------------------------------------------------ _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
