Keyboard input (without auto-repeat turned off) caused weird stuttering effects that rendered CDJ style cue basically useless. Completely disabling auto-repeat makes scrolling through library and tuning eqs and such awkward. This patch deals with the problem by adding a flag in ControlObject to store autorepeat values, and then adds a flag setable in skin files. Adding <AutoRepeat>false</Autorepeat> in a connect now causes that connection to ignore autorepeat key input; defaults to accepts.
This might not be the best way of implementing it (the flag isn't always needed); not really sure how to make it more clean. --gdkar ---------- Forwarded message ---------- From: Nick Guenther <[email protected]> Date: Tue, Aug 11, 2009 at 4:04 AM Subject: Re: [Mixxx-devel] [PATCH] Multi state pushbutton right-click handling. To: gdkarpman <[email protected]> On Mon, Aug 10, 2009 at 5:49 PM, gdkarpman<[email protected]> wrote: > Toggle buttons demonstrate weird actions when triggered by keyboard, because > right-click gets bound to a toggle (which leads to things like cue while > playing being a toggle. Related mess.) > This patch adds a check in wpushbutton.cpp that sets connections to be > non-toggle buttons when they're right-click activated, which fixes the > issue. Also fixes key-off handling in keyboard parsed as midi to let > keyboard scroll through library (was reading key on and key off both as > value 1, not checking the midi category.) I applied your patch and now holding O or E will stutter the track, but at least it's not /moving/ the cue point like that used to. It does seem /different/ at least. This is something that's really been bugging me. CDJ people can do fanciness with their cue button but I find Mixxx's unusable. So, um, keep at it please! -Nick
Added_toggleable_Autorepeat.patch
Description: Binary data
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
