Hey Navaho,
You're correct -- the SoundSource is not deleted, which is a hefty
memory leak. This was fixed in 1.7.1; however, we haven't yet merged the
bugfixes from 1.7.1 to trunk -- so that's why the issue is still present
in trunk. We will definitely do it before the 1.8 release.
Thanks,
RJ
Navaho Gunleg wrote:
> I noticed my memory shrinking -- my RAM I mean... :)
>
> It was causing all types of allocation problems when I clicked a few
> titles one after another, errors I hadn't noticed before because I
> usually just waited for the file to be loaded (they were on an NFS
> mount, but are local now so I can now load the big files :P).
>
> If I understand correctly, loading a song in a player causes the
> 'analyser queue' to be filled up.
>
> I notice the following code in AnalyserQueue::run():
>
> 97 while (!m_exit) {
> 98
> 99 TrackInfoObject* next = dequeueNextBlocking();
> 100
> 101 // Get the audio
> 102 SoundSourceProxy * pSoundSource = new
> SoundSourceProxy(next);
>
>
> I believe this while-loop lacks a 'delete' for this SoundSourceProxy
> object that is getting created: the pointer would get overwritten
> without the previous memory being freed.
>
>
> And, shouldn't ''pSoundSource' be tested after trying to create the
> object? As in something like:
>
> if (pSoundSource == NULL) continue;
>
> The benefit would be that it would cause the errors caused by memory
> problems to be "silently ignored" here rather than having the
> application barfing in an unfriendly manner. :)
>
> (The same test is lacking for the value returned from
> dequeueNextBlocking() -- but I guess, as the name of that routine
> suggest, that it always returns a value and otherwise, well, "blocks"
> i.e. waits?)
>
> Proposed fix is attached...
>
> ------------------------------------------------------------------------
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> ------------------------------------------------------------------------
>
> _______________________________________________
> Mixxx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
