Albert Santoni wrote:
> unistd.h is only available on Unix-based OSes. Please use #ifndef
> __WINDOWS__ instead of _MSC_VER.

I would, but that messes up mingw. I left it as _MSC_VER for now.

I can now build with m4a support. Changes needed have been pushed to trunk.

> Run these tests again with pitch-independent time stretch. Do you
> still have ASSERTs when running at 1 ms? Do you still hear the loud
> pop? It sounds like there might be a problem in the linear
> interpolation code (enginebufferscalelinear.cpp).

And it seems you're correct. All those problems (including the
resampling noise) are gone when I use PITS, but NOT the loud pop on
start. That's still there, but it's only when I build with msvcdebug, so
it's not a big deal since users won't see it.

> File a bug for these...

Done. I targeted them for 1.8.0.

>> - Dragging & dropping from the library causes Mixxx to hang (though the
>> currently-playing deck still continues.)
> 
> Hang for how long?

Forever. Apparently dragging and dropping confuses the reader (or
deadlocks something.) Here's me right-clicking and choosing Load in
Player 1 (same if I just double-click):

Debug: [Main]: Running Mixxx
Debug: [Main]: TrackDAO::getTrack QThread(0x2b08400, name = "Main")
"qt_sql_default_connection"
Debug: [Main]: TrackInfoObject: emitting bpmUpdated signal!
Debug: [Main]: setCuePoints 0
Debug: [AnalyserQueue 1]: AnalyserWaveform: f  44100
samplesPerDownsample:  110  downsamples  410050  from  45105408
Debug: [Main]: Received waveform from track

That's a normal load. Now I drag & drop the same track to Player 1:

Debug: [Main]: TrackDAO::getTrack QThread(0x2b08400, name = "Main")
"qt_sql_default_connection"
Debug: [Main]: TrackDAO::updateTrackInDatabase QThread(0x2b08400, name =
"Main") "qt_sql_default_connection"
Debug: [Main]: Updating track "Whitney Houston, I'm Your Baby Tonight"
in database...
Debug: [Reader 1]: Couldn't load track with filename:  ""
Debug: [AnalyserQueue 1]: AnalyserWaveform :: Waveform downsampling
finished.
Debug: [AnalyserQueue 1]: AnalyserWaveform :: Generation took  16.218
seconds

So far, no freeze, but it's been set up. (That Debug: [Reader 1]:
Couldn't load track with filename:  ""  looks suspicious since I don't
see that on a successful load.) Now I double-click the same track:

Debug: [Main]: TrackDAO::getTrack QThread(0x2b08400, name = "Main")
"qt_sql_default_connection"
Debug: [Main]: TrackInfoObject: emitting bpmUpdated signal!
Debug: [Main]: setCuePoints 0
Debug: [Main]: TrackDAO::updateTrackInDatabase QThread(0x2b08400, name =
"Main") "qt_sql_default_connection"
Debug: [Main]: Updating track "" in database...

...and she's frozen. (The GUI at least.)

Sean

------------------------------------------------------------------------------
The Planet: dedicated and managed hosting, cloud storage, colocation
Stay online with enterprise data centers and the best network in the business
Choose flexible plans and management services without long-term contracts
Personal 24x7 support from experience hosting pros just a phone call away.
http://p.sf.net/sfu/theplanet-com
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to