Maybe I'm totally confused again. Sean, you said you fixed the original "scratch backwards and forwards are at different rates bug" in fixes_scratch, but Owen said he already fixed it in his branch. Owen didn't say anything about his fix breaking existing controls or changing the way the scratch CO works, so why don't we just use his fix?
Albert On Fri, Apr 9, 2010 at 6:49 AM, Owen Williams <[email protected]> wrote: > On Fri, 2010-04-09 at 07:54 +0200, Sean M. Pappalardo - D.J. Pegasus > wrote: >> >> Albert Santoni wrote: >> > Owen wrote in engine/ratecontrol.cpp.... >> >> Duh, I saw that, sorry. But to which branch does it apply? > > trunk. In the old 1.7 branch, all the work is in > engine/enginebuffer.cpp. The code is different, but the idea behind the > fix is the same. > >> >> > But I thought we were proposing changing the behaviour of >> > vinylcontrol.cpp, like just making some changes to use scratch_enable >> > in addition to what it does in 1.8. ?? >> >> That's what I'm saying. (Has vinyl control changed much between 1.7 and >> 1.8 trunk?) > > vinyl control didn't change much, but the engine/ stuff did. > > > owen > > ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
