Hello everyone.

Since it seems Shoutcast/Icecast support is close to being ready for 
testing and has been sitting for months in that state, and we have LOTS 
of requests for it, I want to see it done for 1.8.x.

To that end, I looked at the TODO, 
http://mixxx.org/wiki/doku.php/1.8.0_to_do_list#shoutcast and focused on 
the crashing issue since that seems to be what's holding this up. So I 
went into #icecast and a very nice ph3-der-loewe (who is CCed here) took 
a look at the engineshoutcast.cpp code in trunk and gave me some pointers:

        <ph3-der-loewe> m_pConfig->getValueString().data() can return NULL?
        <Pegasus_RPG>   Apparently 
http://doc.trolltech.com/4.6/qstring.html#data 
and http://doc.trolltech.com/4.6/qbytearray.html#data
        <ph3-der-loewe> it if returns NULL you should skip the corresponding 
shout_set_*()
        <ph3-der-loewe> in case of username it is important that you default to 
'source'
        <ph3-der-loewe> maybe add some printf()s or what ever debug interface 
you use within Mixxx and have a look if there are some NULLs and if the 
username is set up correctly.

Since I know nothing about Shoutcast and have never used it, I'm 
thinking Madjester or someone else familiar with testing it should try 
these changes and see if they fix the crashing issue. (Or tell me how I 
can test it.)

Thanks for your attention and cooperation. This is one more step toward 
commercial feature parity for us, and it looks like we're so close!

Sincerely,
Sean M. Pappalardo
"D.J. Pegasus"
Mixxx Developer - Controller Specialist

------------------------------------------------------------------------------

_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to