Hi guys, I've had to make one more change to our playback rate calculation. It was recently with a patch from Adam Bellinson that aimed to solve slow jog wheels, and it did so by turning a division by 10 into a multiplication by 10 in front of our "wheel" factor.
Unfortunately, that code path only executes during playback, not when a song is stopped. I just noticed scratching the waveform was not going at the intended speed (it also uses the "wheel" control), and I realized there's a giant problem with these changes. The rate calculation for "wheel" must be the same for each code path, otherwise we force every part of Mixxx (waveform) and every MIDI script to be aware of whether or not playback is ongoing. That's just plain silly. For any given rate control, the expectation should be that it behaves the same during playback as it does when the song is stopped. If you want seeking with your "wheel" jogs to go slower or faster depending on whether playback is ongoing, then you're going to have to modify your MIDI script to do that, sorry. This change in behaviour is in the 1.8 branch, r2510. Now's a good time to test your MIDI controllers... :) Thanks, Albert ------------------------------------------------------------------------------ This SF.net email is sponsored by Make an app they can't live without Enter the BlackBerry Developer Challenge http://p.sf.net/sfu/RIM-dev2dev _______________________________________________ Mixxx-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mixxx-devel
