Hi Albert,

Awesome, this looks good. A couple comments:

* In NumarkMixTrack.playFromCue you seem to have a simpleCue mode
implemented in script. Is there a reason you don't just use the
"cue_default" control? cue_default does exactly what you're doing in this
function, except it checks the CDJ Preference in the Mixxx Preferences ->
Interface section ("CDJ" or "Simple" cue modes).

* In some places you have "// FIXME: Get correct sample rate and channels
from deck". Just so you know, the number of channels is always 2. Also, in
Mixxx 1.9.0, we will officially introduce a "track_samplerate" control which
you can use to get the track's samplerate.

* I'm very curious about what your 'jog' handling code is based on :)

* It looks like you've done some neat looping features in-script. Not sure
when, but our current simple implementation of looping will get more
advanced over time. Hopefully we'll implement some of the sort of things I
see on the MixTrack inside the mixing engine.

I would cross-post this to the Controller Mapping section on the forums, as
there are plenty of people there who are not on this mailing list. When you
think this is ready for inclusion, let us know and we can include it in the
next Mixxx release.

Mixxx Forums: Controller Mapping
Forum<http://mixxx.org/forums/viewforum.php?f=7>

Thanks!
RJ Ryan



On Sat, Oct 9, 2010 at 11:52 PM, Albert School <[email protected]> wrote:

> Greetings
>
> I've attached a partial / functional mapping for
> http://www.numark.com/mixtrack
>
> Needs output mappings to trigger lights and so forth.
>
> Cheers,
>
> Albert
>
> ------------------------------------------------------------------------------
> Beautiful is writing same markup. Internet Explorer 9 supports
> standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
> Spend less time writing and  rewriting code and more time creating great
> experiences on the web. Be a part of the beta today.
> http://p.sf.net/sfu/beautyoftheweb
> _______________________________________________
> Mixxx-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
>
------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to