Hey Mika,

The main reason against refactoring too much is that you may cause
merge-hell for the 20 or so outstanding
branches<http://code.launchpad.net/mixxx>that will be looking to merge
to trunk in the near future. If you stick to
the library code, there shouldn't be too many problems in that area.

cheers,
RJ

On Mon, Jan 31, 2011 at 5:08 PM, Mika Haulo <m...@haulo.fi> wrote:

> Hey guys,
>
> It looks like the code in *feature classes (crate, playlist, brower etc.)
> has become a little bit messy and there is a lot of unncessary duplicate
> code. I think that code should be cleaned up. Not only it makes sense in
> general, but a clean codebase is also much more pleasant for any new
> developer joining or planning to join Mixxx development. I remember the
> first time I had a look at Mixxx code, about 2 or 3 years ago. To be honest,
> it was a complete turn-off back then. I'm happy to see the code is much
> cleaner nowadays.
>
> I'm wiling to do some refactoring and there's already some experimental
> stuff in my branch
> https://code.launchpad.net/~mhaulo/mixxx/feature-refactoring. I'm trying
> to avoid any functional changes, and only rearrange the code to make it
> cleaner.
>
> Any comments? Ideas? Objections?
>
>
>
>
>
>
> ------------------------------------------------------------------------------
> Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
> Finally, a world-class log management solution at an even better
> price-free!
> Download using promo code Free_Logger_4_Dev2Dev. Offer expires
> February 28th, so secure your free ArcSight Logger TODAY!
> http://p.sf.net/sfu/arcsight-sfd2d
> _______________________________________________
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
------------------------------------------------------------------------------
Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)!
Finally, a world-class log management solution at an even better price-free!
Download using promo code Free_Logger_4_Dev2Dev. Offer expires 
February 28th, so secure your free ArcSight Logger TODAY! 
http://p.sf.net/sfu/arcsight-sfd2d
_______________________________________________
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to