Well done Max, I've been thinking something like that needed to happen
too!!!
On 29 May 2012 00:35, Max Linke <max_li...@gmx.de> wrote:
> Hi
>
> I've noticed yesterday that we have some common code in different TM.
> I've prepared a small patch that adds functions to BSTM if they are the
> same in different derived TMs, gets rid of some unused variable
> warnings and unified the code at places where different TMs did the
> same but took 2 different approaches.
>
> One thing I didn't change were the search functions. Now all children
> of BSTM have this code for search
>
> void ChildTableModel::search(const QString& searchText) {
> // qDebug() << "CrateTableModel::search()" << searchText
> // << QThread::currentThread();
> emit(doSearch(searchText));
> }
>
> and this for slotSearch
>
> void ChildTableModel::slotSearch(const QString& searchText) {
> BaseSqlTableModel::search(
> searchText, LibraryTableModel::DEFAULT_LIBRARYFILTER);
> }
>
> Wouldn't it be better to declare search and slotSearch only in BSTM and
> let the children use these inherited functions instead of this rather
> strange construct.
>
> best Max
>
> ------------------------------------------------------------------------------
> Live Security Virtual Conference
> Exclusive live event will cover all the ways today's security and
> threat landscape has changed and how IT managers can respond. Discussions
> will include endpoint security, mobile security and the latest in malware
> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
--
keithsalisb...@gmail.com
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
