Hello
It has been a long time since I last mailed. So, just for a recap: I was
working on the following bug:
bug#1000784<https://bugs.launchpad.net/mixxx/+bug/1000784>.
(I'm using mixxx on ubuntu 12.04..)
I'm sorry for such a late reply.. I was not sure if I had done enough, also
I was busy with college related work. I never got the errors reported from
taglib. I tried corrupting the files by opening them in text editors and
modifying them. Also there is this site which corrupts mp3 docx etc files.
Tried that too, no luck( no luck in the sense.. there was no error reported
by taglib.. and thus even the corrupt files were present in the library
after the scanning process was completed).
I tried a couple more things too:
in the source code, I changed the sample rate to -1(m_iSampleRate=-1); and
ran it. For example, when I was playing mp3 files, in
src/soundsourcemp3.cpp.. I made two modifications to see how the output
would be, and to check the debug and warning messages in the terminal. In
line 357 i added a command: m_iSampleRate=-1; and at the end of switch case
again, I modified the line 391 from m_iSampleRate=44100; to
m_iSampleRate=-1;. Although, I didn't expect taglib to be offended by
this...but I hoped, during the parsing process, taglib would be offended,
because now m_iSampleRate is a negative number, and hence hoped there would
be an error message in the terminal from taglib. There were error messages
reported both by qDebug() and qWarning().. but none by taglib..of the likes
of: "TagLib: MPEG::Header::parse() -- Invalid sample rate".
One more thing I tried as Daniel asked me to do was(or rather what I
understood of what he told) , in all parseHeader() functions in all of the
soundsource.cpp files, I deleted "return OK", and hence forced them all to
return ERR, no matter the file be corrupted or not. But still,I was able to
rescan the library with the same set of proper songs and also corrupted
songs were loaded. I was surprised when mixxx was still able to play songs,
even though all the parseHeader() functiones were returning ERR or false.
Should I be surprised? In some more cases, when I had made more tweaks to
the source code, to forcefully input/read corrupt files, the proper
songs(non-corrupted files) didn't load or even if they loaded they didn't
play, and when I tried loading corrupt songs to the deck, mixxx crashed.
But the common point is, in the terminal, there were no error messages
reported by taglib, and all the songs(corrupt or not) were listed in the
library...
So considering all this, what I would like to know is.. whether we can
conclude that libraryscanner does scan and list even the corrupt files? And
in case, the loaded files are corrupt, they would be notified while trying
to load them onto the deck and/or while trying to play it.
Cheers
Priyadarsi
On Tue, Mar 12, 2013 at 5:18 PM, Sean M. Pappalardo - D.J. Pegasus <
[email protected]> wrote:
>
>
> On 03/12/2013 11:54 AM, Uma Priyadarsi wrote:
>
>> This bug caught my attention: bug#1000784
>>
>
> You can ask for more information in the bug report as well. I just grepped
> for 'taglib' in src and it's mentioned in all of the soundsource cpp files.
> So open them, search for taglib and you would add some code to qDebug() the
> file name if taglib returns an error.
>
>
>
> Sincerely,
> Sean M. Pappalardo
> "D.J. Pegasus"
> Mixxx Developer - Controller Specialist
>
>
------------------------------------------------------------------------------
Own the Future-Intel(R) Level Up Game Demo Contest 2013
Rise to greatness in Intel's independent game demo contest. Compete
for recognition, cash, and the chance to get your game on Steam.
$5K grand prize plus 10 genre and skill prizes. Submit your demo
by 6/6/13. http://altfarm.mediaplex.com/ad/ck/12124-176961-30367-2
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
