Hi Ferran,
Thank you for your contributions!
the warning is calculated and rendered here:
src/waveform/renderers/waveformrendererendoftrack.cpp
m_remainingTimeTriggerSeconds(30.0)
and here:
src/widget/woverview.cpp
according to a "end_of_track" ControlObject, written by
waveformrendererendoftrack.cpp.
--
So a straight forward solution is, to initialize
m_remainingTimeTriggerSeconds(30.0) from the WaveformWidgetFactory
similar to:
bool WaveformWidgetFactory::setConfig(ConfigObject<ConfigValue> *config){
You can reinitialize the waveforms like what happens if you change the
waveform type, for instant effect of the "end of track threshold" change.
--
Probably the best solution is to remove the "End of track warning"
calculation from the waveformrendererendoftrack.cpp, since this is called
very often with the waveform framerate. Maybe src/basetrackplayer.cpp is
the right place. It might control "end_of_track" by "playposition" and a
new slot from your config value change.
I would be happy if you will go this way.
Thank you,
Daniel
2013/7/24 Ferran Pujol Camins <ferranpujolcam...@gmail.com>
> Hello! I'm trying to add functionality to allow the user to choose when
> the end of track warning starts, as requested in a easy bug.
> At the moment I've managed to add a spinbox to preferences and to store
> the selected value. But I'm a bit confused on how to change the hardcoded
> value for the preferences one.
>
> In *dlgprefcontrols.cpp* I've added a *slotSetTrackEndWarningTime*function
> that sets the
> *ConfigOption*. If I understood the code well, it should also update the
> value wherever it should, in order of the waveform engine to use the new
> one.
>
> I have also added a *slotSetRemainingTimeTriggerSeconds(int time)* in *
> waveformrendererendoftrack.cpp* that sets the *
> m_remainingTimeTriggerSeconds* property of this object.
>
> However, I don't know ho should I use this slot, as Idon't really
> understand how renderers are used. Also, I am going in th good direction?
>
>
> Best Regards, Ferran Pujol Camins
>
>
> ------------------------------------------------------------------------------
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
