Hi Peter,
and thanks for the patch.
We decided against the static display of the native musical key in default
skins (<Property>key</Property>) before, see
https://bugs.launchpad.net/mixxx/+bug/1159141.
A Key detection feature was merged to current dev-branch some days ago, that
allows for a more intelligent key widget. Skins will undergo some serious
changes for the 1.12 release once the major features are merged, one of them
being the intelligent key widget. So adding a static key widget is not strictly
necessary.
Your forum post is a good place to make the changes instantly available for
users of the current stable version.
Thanks again, and keep the ideas coming...
---
jus
On Dec 9, 2013, at 1:20 PM, Peter G. Marczis <marc...@demonkutya.com> wrote:
> Hi everyone !
> I really would like to get deeper into Mixxx project, and I just started to
> check the code here and there... So I found out that Mixxx has now key
> detection, which is super cool as see... My only problem was with that I
> can't see the key of the loaded track, and my memory is way too short to
> remember. So I managed to figure out how to add it to the skin I use...
> Sorry long story at the beginning, what I would like to ask:
> - Do you think that this is useful ?
> - If yes, I'm willing to add it to all of the skins... (may take some time
> to test properly:)
> - Do you think that the change is okay ? Do I miss something ?
>
> Thanks in advance !
>
> Br,
> Peter.
>
> P.S.: I did the diff on the git trunk. Seems to work as expected, but I can't
> tell of course...
> <keystoskin.diff>------------------------------------------------------------------------------
> Sponsored by Intel(R) XDK
> Develop, test and display web and hybrid apps with a single code base.
> Download it for free now!
> http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk_______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
