Ah,

Good to know: I thought we were already targeting Qt5 for next release, but if 
this is not the case I would not worry too much right now.

It was maybe the qml-based skinning system which required Qt5 or something? And 
that’s not coming for Qt5?

Sorry I’m just lost with the features :)

BTW, those new build problems I discovered with OS X were solved later and are 
added to my pull request filed yesterday: the new thread timer stuff was 
incomplete for other platforms than linux, duplicating copied functions with 
same names as in src/util/performancetimer.cpp and resulting to linker errors. 
My trivial patch leaves only the linux threadcputimer implementation to 
src/util/threadcputimer.cpp and uses the default dummy for other platforms.

Of course if we need the threadcputimer classes for other platforms than linux 
these functions need to be implemented, but I understood this is just a linux 
profiling class, not necessary for normal operation?

        *hile*

On 02 Mar 2014, at 22:08, Daniel Schürmann <dasch...@mixxx.org> wrote:

> Hi Ilkka, 
> 
> your investigations are correct. The the merged touch patch solves some 
> issues that are already solved in Qt5.  
> And there is actually work to do to make some changes conditional for 
> compiling with Qt5. 
> 
> I have filed a wiki page with some details: 
> http://www.mixxx.org/wiki/doku.php/touch
> 
> The changes in the skin engine are not requiring Qt5. Mixxx 1.12 will be a 
> Qt4 release. 
> 
> Do you need a Qt5 Version of Mixxx and why? I was not successful to compile a 
> working one with Ubuntu even before the patch. 
> 
> But I will file a Bug for 1.13 and give Qt5 compile an other try now. Maybe 
> you can give some hinds later If it does not work for me. 
> 
> Kind regards, 
> 
> Daniel 
> 
> 
> 
> 
> 
> 
> Am 02.03.2014 11:15, schrieb Ilkka Tuohela:
>> 
>> Hi,
>> 
>> Recently merged patch to support touch events breaks compile with Qt5: the 
>> touch API was added to quite late versions of Qt4 and it seems it was only a 
>> draft version, reimplemented for Qt5 slightly differently.
>> 
>> It’s quite obvious when you compare public functions on following pages:
>> http://qt-project.org/doc/qt-4.8/qtouchevent.html
>> http://qt-project.org/doc/qt-5/qtouchevent.html
>> 
>> Compilation fails because there is not ‘widget’ attribute (it’s ‘window’ and 
>> of different type anyway). Of course this is just the first point where it 
>> fails, for sure there are other issues like that.
>> 
>> Was it so that the new skinning system will require Qt5 anyway? In this case 
>> the patch should be reverted and updated to use Qt5 before new merge. If we 
>> wish to support both Qt4 and Qt5 it needs to detect version and act 
>> differently.
>> 
>>  *hile*
>> 
>> 
>> 
>> ------------------------------------------------------------------------------
>> Flow-based real-time traffic analytics software. Cisco certified tool.
>> Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
>> Customize your own dashboards, set traffic alerts and generate reports.
>> Network behavioral analysis & security monitoring. All-in-one tool.
>> http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk
>> 
>> 
>> _______________________________________________
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>> 
>> 
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
> 
> ------------------------------------------------------------------------------
> Flow-based real-time traffic analytics software. Cisco certified tool.
> Monitor traffic, SLAs, QoS, Medianet, WAAS etc. with NetFlow Analyzer
> Customize your own dashboards, set traffic alerts and generate reports.
> Network behavioral analysis & security monitoring. All-in-one tool.
> http://pubads.g.doubleclick.net/gampad/clk?id=126839071&iu=/4140/ostg.clktrk_______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
> 
> 
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel

------------------------------------------------------------------------------
Subversion Kills Productivity. Get off Subversion & Make the Move to Perforce.
With Perforce, you get hassle-free workflows. Merge that actually works. 
Faster operations. Version large binaries.  Built-in WAN optimization and the
freedom to use Git, Perforce or both. Make the move to Perforce.
http://pubads.g.doubleclick.net/gampad/clk?id=122218951&iu=/4140/ostg.clktrk
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org


Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel

Reply via email to