Hi Peter,
you can just push to the same branch again and GiHub will update the PR.
Kind regards,
Daniel
2014-04-25 10:32 GMT+02:00 Peter G. Marczis <marc...@demonkutya.com>:
> Okay,
> thanks a lot, I'm kind of familiar with the process, got one fix already
> into the release :) (minor one of course)
> But the early review is a good idea thanks !
> Is it so that I can update the pull request, or just will make a new when
> I'm really ready ?
> Br,
> Peter.
>
>
> On Fri, Apr 25, 2014 at 9:01 AM, Daniel Schürmann <dasch...@mixxx.org>wrote:
>
>> Hi Peter,
>>
>> thank you for your work.
>>
>> I am afraid we are slightly behind the schedule. So good news for you.
>>
>> The best way to include your work into the release branch is to issue a
>> GitHub pull request.
>> It is OK if you make a pull request for unfinished version now, just
>> leave a comment at the PR about the current state.
>> This way there is a chance to get comments from mapping experts in an
>> early state.
>>
>> Here you will find hints about the workflow:
>> http://www.mixxx.org/wiki/doku.php/bugfix_workflow
>>
>> Kind regards,
>>
>> Daniel
>>
>>
>>
>>
>>
>>
>> 2014-04-24 23:45 GMT+02:00 Peter G. Marczis <marc...@demonkutya.com>:
>>
>>> Hi everyone !
>>> Just wondering if you have some release plan for the next release, as
>>> I'm working on Novation Launchpad Mini mapping, and I really would like to
>>> get my results into the next release, if its passing the code review...
>>> But as always I have limited time for the project, and still not reached
>>> the first release ready state...
>>> (I can now control the lights, have "virtual pages" so you get 8*64
>>> buttons virtually, and hotcues are now mapped to the first page, they work
>>> stable getting status from controller and from mixxx too...
>>>
>>> I'm planning to use it as a secondary controller, so i dont really
>>> planning to map everything to it, but I think its really easy to add
>>> mappings into my code now... (anyway maybe the code is terrible, as this is
>>> my very first javascript monster...)
>>>
>>> Okay, got too far, sorry, its late here...
>>>
>>> The question if I have some deadline already or its just far in this
>>> year ?
>>>
>>> Thanks in advance !
>>> Br,
>>> Peter a.k.a. MPG. :)
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Start Your Social Network Today - Download eXo Platform
>>> Build your Enterprise Intranet with eXo Platform Software
>>> Java Based Open Source Intranet - Social, Extensible, Cloud Ready
>>> Get Started Now And Turn Your Intranet Into A Collaboration Platform
>>> http://p.sf.net/sfu/ExoPlatform
>>> _______________________________________________
>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>> http://mixxx.org
>>>
>>>
>>> Mixxx-devel mailing list
>>> Mixxx-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>>
>>
>>
>
------------------------------------------------------------------------------
Start Your Social Network Today - Download eXo Platform
Build your Enterprise Intranet with eXo Platform Software
Java Based Open Source Intranet - Social, Extensible, Cloud Ready
Get Started Now And Turn Your Intranet Into A Collaboration Platform
http://p.sf.net/sfu/ExoPlatform
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
