Hi Jan,
just found your Mail in my Spam folder.
Thank you for working on this.
There is also a unmerged bazaar branch issuing this topic:
https://code.launchpad.net/~oberling/mixxx/feature_first-beat-in-bar/+merge/155096
Please read the discussion and the related bugs.
Maybe you can reuse tome code?
This might be helpful as well:
http://www.mixxx.org/wiki/doku.php/bugfix_workflow
It is best, to finally discuss your code at a GitHub pull request. It is no
problem to issue one if you are still working.
I did not get your point about what makes the 16th bar special?
Wat is the underlying use-case?
Do you have a link for further reading about 16th bar?
Thank you,
Daniel
2014-07-01 16:49 GMT+02:00 Jan Dohl <poly...@wh2.tu-dresden.de>:
> Hello,
>
> New to hacking mixxx and hopefully my first contribution.
>
> I made a small patch that colors every 4th and 16th beat of a song
> differently. To that end, you set a "root beat" which will be used as
> reference 16th beat. It's meant as a visual aid of the song structure
> but has also proven practical when seeking 16 beats before a break or
> similar.
>
> To that end, the colors can be set in the theme (for now, only
> LateNight1280x800-WXGA is modified, but it's easily extended to the
> others) and the BeatGrid protobuf was added a new field for the root
> beat so it is preserved. The code is available here:
>
> https://github.com/polygon/mixxx/commits/color_beat_grid
>
> It's currently very hacky. If there's interest in including this feature
> I'd polish it. Things that probably need changing:
>
> - Support BeatMap, currently only supports BeatGrid (is that a problem?)
> - Feature is currently bound to the Adjust Beatgrid function, should
> probably be separated into its own button (which I haven't figured out yet)
>
> Any comments welcome.
>
> Regards,
> Jan
>
>
> ------------------------------------------------------------------------------
> Open source business process management suite built on Java and Eclipse
> Turn processes into business applications with Bonita BPM Community Edition
> Quickly connect people, data, and systems into organized workflows
> Winner of BOSSIE, CODIE, OW2 and Gartner awards
> http://p.sf.net/sfu/Bonitasoft
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
------------------------------------------------------------------------------
Open source business process management suite built on Java and Eclipse
Turn processes into business applications with Bonita BPM Community Edition
Quickly connect people, data, and systems into organized workflows
Winner of BOSSIE, CODIE, OW2 and Gartner awards
http://p.sf.net/sfu/Bonitasoft
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
