Hey Keith,
Welcome back! While getting Varun's code ready to merge I had to roll back
all the track selector stuff because we were just adding key detection /
pitch shifting to the release and Varun had merged with your branch during
GSoC. I batched this all into one commit so it would be easy to revert in a
private branch to continue work:
Here it is:
https://github.com/mixxxdj/mixxx/commit/8614b4a3e77cc34fe55c028caa405da900d4446f
Cheers,
RJ
On Thu, Jul 17, 2014 at 2:01 PM, keithsalisb...@gmail.com <
keithsalisb...@gmail.com> wrote:
> Great news. Should be free in August also Max, so yes definitely happy to
> work together with you on this. I'd really like to see the key and bpm
> filters in the next version as I had so much fun using them last year. I
> have some ideas to make it fit better within the UI, and I'd like to make
> it a toggle-able view, just like the samplers, preview track etc. The track
> similarity stuff sounds great, though possibly an expensive and advanced
> feature so we'll have to see. I only have a month so I'd really like to
> keep the scope of my contribution to something small enough it can be
> completed to production quality in the time I have, ready for merging.
>
> Thanks for the background Daniel, looking forward to getting stuck in!
>
>
> On 17 July 2014 11:55, Max Linke <max_li...@gmx.de> wrote:
>
>> On Thu, 2014-07-17 at 10:27 -0400, keithsalisb...@gmail.com wrote:
>> > Hey guys,
>> >
>> > Got some free dev time coming up next month and I'd really like to get
>> my
>> > Active Library Filters branch ready for consideration for the main
>> trunk.
>> >
>> > https://code.launchpad.net/~keithsalisbury/mixxx/track_selector_feature
>> >
>> > Does anyone have any knowledge of this area of the code base who could
>> shed
>> > some light on the updates since 1.11. Was there any particular reasons
>> it
>> > wasn't considered for inclusion prior to now? I know we've got key
>> notation
>> > analysis working (really sweet feature btw!!) so that should make the
>> > Filters code lighter which is always nice.
>>
>> We had a GSoC student working on this last year. He used some of your
>> code if I remember correctly.
>>
>> https://www.google-melange.com/gsoc/project/details/google/gsoc2013/chrisjr/5876975549808640
>>
>> Has has written a bit about his implementation
>> http://gsoc2013-mixxxtracksuggestions.blogspot.de/
>>
>> This is now using filters to do get a rough list of possible tracks and
>> then calculates a score based on a track similarity measure.
>>
>> I've started a bit to clean up his branch and and make it ready to merge
>> it into master.
>> https://github.com/kain88-de/mixxx/tree/track_selector
>>
>> I'm currently busy with work but I'll have free time in August and my
>> plan was to finish this work then.
>>
>> I'm also happy if you want to work on this, I can help you with that and
>> use the time to fix other things in mixxx.The new selector-table is
>> still using the the Control-objects, this would need to be updated, and
>> I planned to add some tests for the similarity calculations. The UI
>> could still use some work, it is not super intuitive currently.
>>
>> best Max
>>
>> >
>> > I also see there's been a move towards git/github? Does that mean the
>> code
>> > proposal process has changed to github as well? Does that mean my best
>> bet
>> > is to fork off github and rework my code into that then send a pull
>> request
>> > or something?
>> >
>> > any info would be great, looking forward to getting stuck in again....
>> >
>> > tia
>> > keith
>> >
>> ------------------------------------------------------------------------------
>> > Want fast and easy access to all the code in your enterprise? Index and
>> > search up to 200,000 lines of code with a free copy of Black Duck
>> > Code Sight - the same software that powers the world's largest code
>> > search on Ohloh, the Black Duck Open Hub! Try it now.
>> > http://p.sf.net/sfu/bds
>> > _______________________________________________ Get Mixxx, the #1 Free
>> MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>> Want fast and easy access to all the code in your enterprise? Index and
>> search up to 200,000 lines of code with a free copy of Black Duck
>> Code Sight - the same software that powers the world's largest code
>> search on Ohloh, the Black Duck Open Hub! Try it now.
>> http://p.sf.net/sfu/bds
>> _______________________________________________
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>
>
>
>
> --
> keithsalisb...@gmail.com
>
>
> ------------------------------------------------------------------------------
> Want fast and easy access to all the code in your enterprise? Index and
> search up to 200,000 lines of code with a free copy of Black Duck
> Code Sight - the same software that powers the world's largest code
> search on Ohloh, the Black Duck Open Hub! Try it now.
> http://p.sf.net/sfu/bds
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
------------------------------------------------------------------------------
Want fast and easy access to all the code in your enterprise? Index and
search up to 200,000 lines of code with a free copy of Black Duck
Code Sight - the same software that powers the world's largest code
search on Ohloh, the Black Duck Open Hub! Try it now.
http://p.sf.net/sfu/bds
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
