Good call, this does look like a 2nd-deck sync issue. Once I nudge the decks into sync, I can push "beats_translate_to_sync" on either deck, as well as the deck 1 sync button, and everything stays in sync. But as soon as I hit the deck 2 sync button, deck 2 jumps forward by about 2000 samples.
And here's an easier repro: turn quantize on, take two tracks that have the same BPM and play them with the default playback speed of +0.00. Hitting sync on either deck should put and keep them in sync (assuming the beat detection algorithm did a good job, which it usually does). Now change the playback speed to, for example, -2.00. Now hitting sync on deck 1 sounds good but hitting sync on deck 2 puts them out of phase. If there is not already a bug for this, I can create one if you would like. I'll also submit the pull request for the new feature. Are there new skins for 1.12 hiding somewhere, or is it just what I see in "/res/skins"? On Tue, Aug 12, 2014 at 5:51 PM, Owen Williams <owilli...@mixxx.org> wrote: > Do you know if it's syncing forward or backwards, for instance? > > On Tue, 2014-08-12 at 18:43 -0400, Owen Williams wrote: > > I think there is an off-by-one-buffer error in the sync code. When you > > push the sync button, it makes a difference if the deck being synced is > > processed before or after the deck being synced to. > > > > > > > > On Thu, 2014-08-07 at 11:07 -0500, Ryan Kramer wrote: > > > I made this code change > > > ( > https://github.com/default-kramer/mixxx/commit/aaf3e1c96dc1cb3d91fcb905570a9d1a65a33e3e) > and was playing around with it last night. (The feature description is here > https://bugs.launchpad.net/mixxx/+bug/1180052) Everything worked great > with one exception. I am hoping that a more experienced Mixxx developer > will be able to give me some insight. > > > > > > > > > I have two decks stuck in loops. Assume the beatgrids are already in > > > phase. Pushing the new function (which I named > > > "beats_translate_to_sync") should have virtually no effect. And in the > > > normal case, it doesn't - the beatgrid may shift by up to 2 samples, > > > but this does not produce an audible difference when you re-sync to > > > the new beatgrid. But only on deck 2, and only when deck 2 quantize is > > > turned on, it shifts by hundreds or even thousands of samples - this > > > is wrong, and very audible when you re-sync to the new beatgrid. > > > > > > > > > Any ideas? > > > > > > > > > (I'll be busy this weekend so apologies if it takes me a while to > > > respond - I'll be back at this next week for sure.) > > > > ------------------------------------------------------------------------------ > > > Infragistics Professional > > > Build stunning WinForms apps today! > > > Reboot your WinForms applications with our WinForms controls. > > > Build a bridge from your legacy apps to the future. > > > > http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk > > > _______________________________________________ > > > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > > > http://mixxx.org > > > > > > > > > Mixxx-devel mailing list > > > Mixxx-devel@lists.sourceforge.net > > > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > > > > > > > > ------------------------------------------------------------------------------ > > _______________________________________________ > > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > > http://mixxx.org > > > > > > Mixxx-devel mailing list > > Mixxx-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > > > > > >
------------------------------------------------------------------------------
_______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
