Hi Owen, the main work was done by Nicu in the first half of his GSoC project. You will find a kind of design document at http://www.mixxx.org/wiki/doku.php/extending_the_effects_engine and in his detailed weekly reports. He is also about to write a roundup of his work, that will give a better overview. Nicu works also on a merged branch with all EQ changes together.
In short it is this: * Replace the current EQs with an effect slot in a dedicated EQ Rack * Turn the current EQs into effects * Extend the EQ preference page to deal with effects * Alias the legacy EQ controls to the Parameters of the effect rack * Add a Master EQ effect Slot > ie where processing will move, any issues with existing CO / skin compatibility, etc. The change seams to be very self containing. No skin work is required > I'm very sensitive to EQ quality ... Great! There are some pending PRs of new EQ Effects. It is hard for me to decide which is the best and if they are suitable to replace or extend the existing ones. From our measurement results they are notable better but ... Can you give them a try? > ... and while ours aren't The Best, they work nicely and previous changes have caused problems. Yes I am sorry about that. But this fault triggers me to dig deep into the filter theory. The new EQs are all based on this new knowledge. Thank for your help in advanced. Kind regards, Daniel 2014-08-15 16:21 GMT+02:00 Owen Williams <owilli...@mixxx.org>: > Can you make a design doc for how you plan to move the built-in EQs into > the effect framework? ie where processing will move, any issues with > existing CO / skin compatibility, etc. I'm very sensitive to EQ quality > and while ours aren't The Best, they work nicely and previous changes > have caused problems. So I want to be really sure we know what we're > doing when we start rewriting such a core part of the engine. > > On Thu, 2014-08-14 at 08:22 +0200, Daniel Schürmann wrote: > > Hi Mixxx Developers. > > > > > > NIcu and I are working on a EQ Consolidation in Mixxx. We plan a pull > > request, that removes the static deck EQs and replace this with an > > effect slot dedicated for EQs and connected to the legacy EQ > > controls. > > > > > > This way you are able to individual load one of the Mixx EQs or later > > a Plug-In EQ (Lv2/VST/Hardware) as Deck EQs. If yo need no Deck EQ, > > you van use this slot together with the EQ knobs for any other > > effect. > > > > > > Since the EQs are Effects, you can place a EQ on every position where > > you can place an Effect, Mic, Aux, Master, Sampler. > > > > > > Currently there are some pending PRs for new EQ effects. They may > > extend or replace the current Mixxx EQs. > > > > How many EQs are suit to Mixxx? Which types we need, which can be > > ditched. > > What are the usecses? Please consider a static Master EQ and a DJ EQ > > used for Mixing. > > It is wishing time! :-) > > > > We may add: > > Pure Bessel (Round edged) > > Pure Butterworth (Sharp edges / Flat top) > > Linkwitz-Riley (Medium edges, linear group delay) > > > > Bessel LV MIx (Round edged / Minimum Phase / Bit-perfect at unity) > > 8-Band graphic > > ?-Band parametric > > ... > > wish/dream EQ > > ... > > > > The Linear Phase EQ, actually works, but only for long buffer sizes, > > so not that suitable for Mixxx. > > > > Which order makes sens, which roll-off is needed (order 8) = -48 > > db/Oct? > > What is the minimum suitable order in respect to CPU? > > > > Thank you, > > > > Daniel > > > > > > > > > > > > > > > > > ------------------------------------------------------------------------------ > > _______________________________________________ > > Get Mixxx, the #1 Free MP3 DJ Mixing software Today > > http://mixxx.org > > > > > > Mixxx-devel mailing list > > Mixxx-devel@lists.sourceforge.net > > https://lists.sourceforge.net/lists/listinfo/mixxx-devel > > >
------------------------------------------------------------------------------
_______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
