My main complaint hasn't changed -- that change bakes UI decisions
(grouping the parameters by type) into the data model / class hierarchy. It
complicates everything to have multiple sets of parameters (as the enum PR
shows we will have 3 sets of widgets, 3 sets of parameter slots, etc.) when
they're all just copypasta. I don't think the decision there has any
philosophical significance -- we can still do whatever we want in the UI
layer.
The specific implementation is just too much technical debt for us to carry
forward.
On Tue, Sep 9, 2014 at 3:26 PM, Daniel Schürmann <dasch...@mixxx.org> wrote:
> Hi,
>
> I think the current master is already in a good shape to announce a new
> version now.
>
> The final beta should indeed include the EQ Rack and the Cover Art
> support.
> I would not like to face the situation, waiting an other two years for it.
> But we should not do it in a rush.
> So we need to postpone feature freeze a bit.
>
> ---
>
> Button parameters:
>
> I think we cannot save effect chains nor we have a effect featuring
> button, so that is not the issue to block a new version.
>
> But before doing a PR that removes button parameters, we must get a common
> sense how we want to support button
> and enum parameters in 1.12.
>
> I am still convinced that the current state is good and we have proved
> that it is working well.
> The whole EQ Rack model is based on this.
>
> We need them to alias the kill buttons.
> We need them to place Buttons and Knobs individual in a fixed GUI like the
> EQ controls
> Nicu has created an Effect Button Widget that features a right click
> context menu for enums.
>
> @RJ I do not get the point why we should remove them.
> Please continue the discussion at
> https://github.com/mixxxdj/mixxx/pull/281
> Thank you
>
> Kind regards,
>
> Daniel
>
>
>
>
> Am 09.09.2014 um 18:26 schrieb RJ Ryan:
>
> I think the only blocker for a beta is fixing the technical debt
> introduced here:
> https://github.com/mixxxdj/mixxx/pull/281
> The issue is that XML files saving effect chains will have button
> parameters in them. If we let that escape into the wild then we'll need to
> migrate users configs in the future.
> (I'll remove button parameters as a distinction from parameters in a
> future PR).
> As a temporary solution we could release a beta with no effect chain
> saving/loading (I can't remember if this is the current state in master
> anyway).
>
>
> On Tue, Sep 9, 2014 at 12:19 PM, Max Linke <max_li...@gmx.de> wrote:
>
>> I would like to include covers as well. It is close to being mergeable
>> and we
>> kind of promised our students to merge their work into master with our
>> new set
>> of rules. Besides they both did good work this summer and it would be a
>> nice
>> thank you to include it into mixxx 1.12. I don't know when Nicu's work is
>> mergeable and what of his work is best suited for 1.12.
>>
>>
>> best Max
>>
>>
>> On Tue, 09 Sep 2014 12:14:20 -0400
>> Owen Williams <owilli...@mixxx.org> wrote:
>>
>> > Seeing as we're fairly close to being able to make builds for all
>> > platforms again, are there any blockers in trunk against releasing a
>> > beta as soon as possible? I think the skins are in OK shape, effects
>> > work well, etc etc. There's always stuff I'd like to include to make it
>> > better, but I can't think of anything that's inexcusable based on our
>> > goals for this release.
>> >
>> > On Tue, 2014-09-09 at 11:49 -0400, RJ Ryan wrote:
>> > >
>> > >
>> > > On Tue, Sep 9, 2014 at 11:42 AM, Sean M. Pappalardo - D.J. Pegasus
>> > > <spappala...@mixxx.org> wrote:
>> > > Hello, RJ.
>> > >
>> > > That's excellent news all around! Given that, what do you
>> > > suppose the prospects are of doing a release as far before 5
>> > > November as possible? (5 October would be ideal.)
>> > >
>> > >
>> > >
>> > > Given that we need to do an extensive beta (potentially multiple betas
>> > > given how much stuff we're adding) I think it's premature to shoot for
>> > > this deadline.
>> > >
>> > > On 09/09/2014 08:27 AM, RJ Ryan wrote:
>> > > The exciting thing about Windows right now is that I
>> > > have versioned and
>> > > scripted the entire build environment
>> > >
>> > > With one command you can generate a (x86|x64)
>> > > (release|debug) build
>> > > environment.
>> > >
>> > > That _is_ exciting. I assume this covers dependencies as well?
>> > > If so, this would finally allow the uninitiated to build Mixxx
>> > > from nothing on Windows. Please update the Wiki when you can.
>> > >
>> > >
>> > > Yep, this is every single dependency (and the depedencies'
>> > > dependencies -- e.g. zlib, fftw3, etc.). I _think_ it should work on a
>> > > fresh Win7 machine with platform SDK, MSVS 2013 Express and the
>> > > DirectX SDK installed.
>> > >
>> > >
>> > > Currently everything builds as a DLL but we can switch back to static
>> > > linking if need be. If/when we do that we could either add a new
>> > > target to every solution or just change it in bulk -- the nice thing
>> > > will be that it'll all be version-controlled so we can see what has
>> > > been done.
>> > >
>> > >
>> > >
>> > >
>> > > Sincerely,
>> > > Sean M. Pappalardo
>> > > "D.J. Pegasus"
>> > > Mixxx Developer - Controller Specialist
>> > >
>> > >
>> > >
>> > >
>> > >
>> ------------------------------------------------------------------------------
>> > > Want excitement?
>> > > Manually upgrade your production database.
>> > > When you want reliability, choose Perforce.
>> > > Perforce version control. Predictably reliable.
>> > >
>> http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
>> > > _______________________________________________
>> > > Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> > > http://mixxx.org
>> > >
>> > >
>> > > Mixxx-devel mailing list
>> > > Mixxx-devel@lists.sourceforge.net
>> > > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>> >
>> >
>> >
>> >
>> ------------------------------------------------------------------------------
>> > Want excitement?
>> > Manually upgrade your production database.
>> > When you want reliability, choose Perforce.
>> > Perforce version control. Predictably reliable.
>> >
>> http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
>> > _______________________________________________
>> > Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> > http://mixxx.org
>> >
>> >
>> > Mixxx-devel mailing list
>> > Mixxx-devel@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>
>>
>> ------------------------------------------------------------------------------
>> Want excitement?
>> Manually upgrade your production database.
>> When you want reliability, choose Perforce.
>> Perforce version control. Predictably reliable.
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>
>
>
>
> ------------------------------------------------------------------------------
> Want excitement?
> Manually upgrade your production database.
> When you want reliability, choose Perforce.
> Perforce version control. Predictably
> reliable.http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
>
>
>
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Todayhttp://mixxx.org
>
>
> Mixxx-devel mailing
> listMixxx-devel@lists.sourceforge.nethttps://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
>
>
>
> ------------------------------------------------------------------------------
> Want excitement?
> Manually upgrade your production database.
> When you want reliability, choose Perforce.
> Perforce version control. Predictably reliable.
>
> http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>
------------------------------------------------------------------------------
Want excitement?
Manually upgrade your production database.
When you want reliability, choose Perforce.
Perforce version control. Predictably reliable.
http://pubads.g.doubleclick.net/gampad/clk?id=157508191&iu=/4140/ostg.clktrk
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
