I agree with all of you. On one hand, Daniel and Gavin are right, the next release should work seamlessly with mp3s, because there are a lot of users who use this format. On the other hand, merging a 7k+ PR would delay the beta release considerably and we can't afford this also.
Can't we just fix the bug alone, without that major rework? Also, if there are other things that need fixing for the beta release, please let me know. I will try to fix them if they are not too hard for me. Nicu On 20.03.2015 16:49, Owen Williams wrote: > I still need a pointer to what the mp3 bug even is. > > On Fri, 2015-03-20 at 07:43 -0700, Gavin Swanson wrote: >> I exclusively use mp3s with mixxx. I would imagine there is a large >> portion of the mixxx user base that does. >> I do not agree with pushing a beta with this kind of issue, if the >> intent is not to fix it for this release. If the intent is to get the >> beta with all its other features out, and then work this issue through >> the beta cycle so it is fixed for release, I could get behind that. >> At the same time if the fix is a major-rework of the base of mixxx >> then it doesn't make sense to do it during a beta cycle and we should >> push beta until its ready. If it's a 1000 line fix with 6000 lines of >> unit tests (unlikely), that's a different story. >> >> >> my ¢2 >> >> >> -Gavin S >> >> Gavin S >> >> On Fri, Mar 20, 2015 at 7:02 AM, Owen Williams <owilli...@mixxx.org> >> wrote: >> I can't in good conscience approve of merging a 7000-line >> delta change >> to the bedrock of the Mixxx engine, even if it fixes an issue >> with mp3 >> seeking. (I also hate how mp3s skip on the first beat, so I >> can >> sympathize). I understand there are new tests, and I'm really >> thankful >> for those. But it's going to take a long time to go through >> that patch >> and then test to find all the issues with bad tags, weird >> files and >> formats, etc etc etc. I think RJ has a collection of horrible >> mp3s that >> he'll want to test. >> >> To me, sitting two years after the last release, I can't >> justify the >> delay that this merge will inevitably cause -- I think we're >> ready for a >> beta and can tolerate the mp3 issues we have. (by the way, is >> there a >> bug for the mp3 issue you're talking about? I can't find it.) >> >> owen >> >> >> >> On Fri, 2015-03-20 at 09:03 +0100, Daniel Schürmann wrote: >> > The only remaining blocker for me is the seek offset issue >> for mp3s. >> > >> > >> > Since we have a fully reviewed solution in >> > https://github.com/mixxxdj/mixxx/pull/411 of really high >> code quality, >> > verified by a new set of unittests, >> > >> > we should just merge it and release the beta. >> > >> > And yes there is a risk of introducing issues and it surely >> will, but >> > by now it fixes much more issues than it might introduce. >> > >> > >> > Of cause I would be happy about any pending PR that can be >> review and >> > merged before. >> > >> > >> > 2015-03-20 0:35 GMT+01:00 Owen Williams >> <owilli...@mixxx.org>: >> > So how about that release? Do we still have >> crashing problems >> > on >> > windows? is anyone looking in to that? Any other >> blockers? >> > >> > owen >> > >> > >> > ------------------------------------------------------------------------------ Dive into the World of Parallel Programming The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net/ _______________________________________________ Get Mixxx, the #1 Free MP3 DJ Mixing software Today http://mixxx.org Mixxx-devel mailing list Mixxx-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mixxx-devel
