Hello,
Adding Node.js to depencies for testing is little overkill and I don't
know can JShint be runned on QT5 Ecmascript interpreter (searched but
nobody knows it runs on Rhino). I think we'll should at least check
every code manually with jshint and jsbeautify in future we should adopt
usage of jscs (http://jscs.info/) (as we use Google coding style in C++
you can use that in Javascript too.)
Tuukka
22.09.2015, 21:24, Sean M. Pappalardo - D.J. Pegasus kirjoitti:
On 09/22/2015 06:56 AM, Be wrote:
Wouldn't that require making Node.js a dependency for the tests? Is that
worth it?
For testing? I would say so, since it would only be required for
running the tests, not just building Mixxx. Though I have no idea how
heavy Node.js is.
Sincerely,
Sean M. Pappalardo
"D.J. Pegasus"
Mixxx Developer - Controller Specialist
------------------------------------------------------------------------------
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
------------------------------------------------------------------------------
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
