Hello,
It was kind of added for crashes caused by new thread. Many users can't
gdb or use debugger. Thank for fix me :D
Sincerely,
Tuukka
07.12.2015, 21:35, Daniel Schürmann kirjoitti:
> Hi,
>
> the issue was a false positive due to a missing ! that has slipped
> though. I have just fixed it in c99b71c4019f7e821d9da7950b2f527d3e2fbf20
>
> By the way: it was already DEBUG_ASSERT_AND_HANDLE(!isRunning()) { used.
> As simple DEBUG_ASSERT would work as well since it is removed in release
> builds.
>
> The underlying bug was hard to reproduce or a phantom.
> Hopefully we can clarify this by some debug data later.
>
> Kind regards,
>
> Daniel
>
>
> Am 07.12.2015 um 18:55 schrieb Owen Williams:
>> We should fix the underlying bug. If the shoutcast thread isn't getting
>> shut down that's a problem.
>>
>> On Mon, 2015-12-07 at 09:31 -0800, Sean M. Pappalardo - D.J. Pegasus
>> wrote:
>>> On 12/07/2015 09:23 AM, Tuukka Pasanen wrote:
>>>> Hello,
>>>> Yes.. I wrote it message and no it doesn't have any bug. It just noise
>>>> and can be removed.
>>> How about the assert?
>>> DEBUG_ASSERT_AND_HANDLE(isRunning())
>>>
>>> Sincerely,
>>> Sean M. Pappalardo
>>> "D.J. Pegasus"
>>> Mixxx Developer - Controller Specialist
>>>
>>> ------------------------------------------------------------------------------
>>> Go from Idea to Many App Stores Faster with Intel(R) XDK
>>> Give your users amazing mobile app experiences with Intel(R) XDK.
>>> Use one codebase in this all-in-one HTML5 development environment.
>>> Design, debug & build mobile apps & 2D/3D high-impact games for multiple
>>> OSs.
>>> http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
>>> _______________________________________________
>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>> http://mixxx.org
>>>
>>>
>>> Mixxx-devel mailing list
>>> Mixxx-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>
>>
>> ------------------------------------------------------------------------------
>> Go from Idea to Many App Stores Faster with Intel(R) XDK
>> Give your users amazing mobile app experiences with Intel(R) XDK.
>> Use one codebase in this all-in-one HTML5 development environment.
>> Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
>> http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
>> _______________________________________________
>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>> http://mixxx.org
>>
>>
>> Mixxx-devel mailing list
>> Mixxx-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>
> ------------------------------------------------------------------------------
> Go from Idea to Many App Stores Faster with Intel(R) XDK
> Give your users amazing mobile app experiences with Intel(R) XDK.
> Use one codebase in this all-in-one HTML5 development environment.
> Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
> http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
> _______________________________________________
> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
> http://mixxx.org
>
>
> Mixxx-devel mailing list
> Mixxx-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
