On Mon, Jun 27, 2016 at 9:57 AM, Joan Marcè i Igual <j.marce.ig...@gmail.com
> wrote:
> Hi RJ,
> the current idea that we thought with Daniel is to separate each
> LibraryFeature into a plugin that can be loaded when needed (e.g. Rhythmbox
> plugin does not have to be loaded always). and only interact with the
> features via the LibraryFeature interface. This will allow us to do a more
> cleaner code too.
>
By "does not have to be loaded" -- do you mean that there is some cost to
instantiation of the features that you would like to avoid?
By and large, the Library already interacts with LibraryFeatures primarily
via the LibraryFeature interface. In the cases where it doesn't -- there is
usually good reason (i.e. it needs to know that it's talking to the feature
of a specific kind -- e.g. when connecting feature-specific signals).
Looking at library.cpp, there is very little special-casing.
I think Qt plugins here would only make sense if we wanted to make the
library extensible by third parties. There is a significant trade-off in
additional complexity introduced by introducing a plugin API. If we intend
to support backwards/forwards compatibility, we would need to worry ABI/API
compatibility. We have a lot of painful experience with this via
SoundSource and VAMP plugins. I am trying to remove both of these plugin
APIs and I would prefer that we not introduce another.
Best regards,
RJ
> I once saw my professors use the Qt plugins and it seemed easy so that's
> why am asking.
>
> Best regards,
> Joan
>
> On Mon, 27 Jun 2016 at 18:50 RJ Ryan <rr...@mixxx.org> wrote:
>
>> Hi Joan,
>>
>> Could you explain a little bit what Qt plugins would help you do here
>> that you're having trouble doing with pure C++?
>>
>> Why do you need to separate LibaryFeatures from the library?
>>
>> Best regards
>> RJ
>>
>> On Mon, Jun 27, 2016 at 9:46 AM, Joan Marcè i Igual <
>> j.marce.ig...@gmail.com> wrote:
>>
>>> Hello everyone,
>>>
>>> I'm currently working in the Library Layout Redesign and one of the
>>> things that I'm doing is changing many Library's class code. One thing that
>>> is pending from long time ago is to separate the LibraryFeatures from the
>>> Library (avoid using all the LibraryFeatures' constructors) and to do this
>>> I thought in using the Qt Plugins feature. Has anyone experience with it?
>>> Will it be a benefit or a detriment?
>>>
>>> I will be waiting for your answer,
>>> Joan
>>>
>>>
>>> ------------------------------------------------------------------------------
>>> Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
>>> Francisco, CA to explore cutting-edge tech and listen to tech luminaries
>>> present their vision of the future. This family event has something for
>>> everyone, including kids. Get more information and register today.
>>> http://sdm.link/attshape
>>> _______________________________________________
>>> Get Mixxx, the #1 Free MP3 DJ Mixing software Today
>>> http://mixxx.org
>>>
>>>
>>> Mixxx-devel mailing list
>>> Mixxx-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mixxx-devel
>>>
>>
>>
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
Get Mixxx, the #1 Free MP3 DJ Mixing software Today
http://mixxx.org
Mixxx-devel mailing list
Mixxx-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mixxx-devel
