I noticed the following in glav_main.c:

void do_real_exit(int ID, void *data)
{
   int status;

   /* Kill all our children and exit */

   printf("real exit here\n");
   kill(0,9);
   waitpid(pid,&status,0);
   exit(0);
}

void Exit_cb(GtkWidget *ob, long data)
{
   /* Try to exit gracefully, wait 1 second, do real exit */

   write(out_pipe,"q\n\n\n",4);
   gtk_timeout_add(2000,(GtkFunction)do_real_exit,0);
}


Is the kill(0,9) really necessary?  Surely, if it is, then there is a
bug in lavplay, no?  And if it really is necessary, how about:

   kill(pid,9);

or even better...

   kill(pid,SIGINT);

The problem with using 0 as the first arg of kill() is that if some
program starts glav, it gets killed with the kill(0,9) as well.  Bad.
Very bad.

b.

-- 
Brian J. Murrell

Attachment: msg00620/pgp00000.pgp
Description: PGP signature

Reply via email to