On Wed, 12 Oct 2005, Benny With wrote:

> Version 1.8.0.  Build on a Fedora Core 4 system with the enclosed .spec
> file.  Tried only on .qt files generated with lavrec.

        .qt will be going away in the future.  Now would be a good time to
        begin the habit of using the more standard ".mov" extension.  At
        one time there was a container format called "movtar" which used
        the .mov extension so Quicktime began using .qt.  Movtar was removed
        ages ago and beginning with the current CVS version of mjpegtools
        .mov is used for Quicktime (just like the Quicktime movies on the
        Internet).

> lav2wav tries to eat up all available memory.  When this succeeds it's
> killed by the system, thus leaving its job unfinished.
        
        Try the attached patch.  Or wait a couple hours and it will be 
        available via anonymous cvs.

        The bug was introduced when the byte swapping code was added (on 
        big endian systems it's necessary to put the data into little endian 
        byte order).  It's pretty obvious that 'i' is not properly set up
        for the loop anyhow :(

        Cheers,
        Steven Schultz
--- lav_io.c.dist       2005-10-10 10:46:50.000000000 -0700
+++ lav_io.c    2005-10-13 09:06:48.000000000 -0700
@@ -878,10 +878,9 @@
             }
 out:
        for (j = 0; j < channels; j++)
-            qt_audio[(channels*i) + j] = qt_audion[j][i];
-
-        free(qt_audion);
-         return(res);
+            free(qt_audion[j]);
+       free(qt_audion);
+        return(res);
 #endif
    }
    return -1;

Reply via email to