Hi Ronald,

> On Sun, 2006-01-08 at 17:04 +0100, Jean Delvare wrote:
> > Drop the adv7175 register cache, as it is only written to and never
> > read back from. This saves 128 bytes of memory and slightly speeds up
> > the register writes.
> 
> Can this be made a compile-time option? I'd like to keep the register in
> for debugging purposes when required. I'm OK with it being off by
> default.

I may do that if you want, but it'll probably hurt the code readbility.
May I ask what is wrong with using the i2c-dev driver with i2cdump for
debugging purposes instead? I just checked and it seems to work just
fine with my ADV7176 chip, and also the datasheets confirmed that all
suppored chips handle register reads properly.

> The other patches look nice, give me a few days to finish my currently
> pending exams and I'll forward them to the kernel.

Thanks. Good luck with your exams :)

-- 
Jean Delvare


-------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc. Do you grep through log files
for problems?  Stop!  Download the new AJAX search engine that makes
searching your log files as easy as surfing the  web.  DOWNLOAD SPLUNK!
http://ads.osdn.com/?ad_id=7637&alloc_id=16865&op=click
_______________________________________________
Mjpeg-users mailing list
Mjpeg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Reply via email to