Bernhard Praschinger wrote:
> Hallo
> 
> I have got a bug report from Petr, he found in the mjpegtools RC2.
> 
> The patches look ok for me
> 
> Here is his mail:
> I tried to compile the RC2 and encountered the following problems:
> 
> 2) mjpegtools-1.9.0rc2/utils/cpu_accel.c:364,368:
>     implicit declaration of 'memalign'
> 
> missing #include <malloc.h>

If you don't like malloc.h, probably posix_memalign() could be of use.

There is another possible bug in y4mutils/y4mtoqt.c:277
if( qtchroma == QUICKTIME_YUV420 ){...}

Iit might be better to use:
if(strcmp(qtchroma,QUICKTIME_YUV420)==0){...}

as the first one compares address of qtchroma with that of string
literal QUICKTIME_YUV420 which is probably not what was intended
(although under some conditions it will have the desired effect).

Petr
--- y4mutils/y4mtoqt.c.old	2007-05-09 12:18:37.413678750 +0200
+++ y4mutils/y4mtoqt.c	2007-05-09 12:20:17.743949000 +0200
@@ -274,7 +274,7 @@
  * compressed formats it seems.
 */
 
-		if	(qtchroma == QUICKTIME_YUV420)
+		if	(strcmp(qtchroma,QUICKTIME_YUV420)==0)
 			{
 			if	(allow_wrong_yv12 == 0)
 				{
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Mjpeg-users mailing list
Mjpeg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mjpeg-users

Reply via email to