Hi Sam, On Mon, 25 Aug 2008 23:26:50 +0200, Martin Samuelsson wrote: > On Thu, 21 Aug 2008 18:23:51 +0200 > Jean Delvare <[EMAIL PROTECTED]> wrote: > > > On Thu, 21 Aug 2008 17:58:12 +0200, Martin Samuelsson wrote: > > > Now I've done some basic checks for memory leaks, and found none. I'd > > > say go for it. > > > > I'm going to split my patch in 2 parts, one adding the new > > infrastructure and one removing the unused code. Would you possibly > > review these patches? Once reviewed we can schedule them for merge in > > 2.6.28-rc1, I think. > > I've looked through your "[PATCH 1/2] zr36067: Convert to new-style > i2c device binding" and "[PATCH 2/2] Drop legacy mode of most zr36067 > i2c chip drivers", and found nothing to object against. (I might not > agree totally with all the itty bitty details of some of the > formatting, but that's really not important. :) > > Good!
Great, thanks for the review. So I can add your Acked-by on both patches? Now I am waiting for Ronald to comment on them, and if he has no objections I will push the patches to Mauro. Regarding the formatting, I might not always be happy with it myself. As I recall, I tried to respect the style that was used in the drivers. Not being the maintainer thereof, I didn't dare changing it even where I didn't like it too much. If you want to reformat the code to something you like better, I'd suggest that you ask Ronald if he is fine with that and eventually do it in a subsequent patch. Thanks, -- Jean Delvare ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Mjpeg-users mailing list Mjpeg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mjpeg-users
